Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the document of SHOW DELETE, SHOW FRONTEND CONFIG and SET FRONTEND CONFIG function #2192

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DongLiang-0
Copy link
Contributor

@DongLiang-0 DongLiang-0 commented Mar 14, 2025

Versions

  • dev
  • 3.0
  • 2.1
  • 2.0

Languages

  • Chinese
  • English

Docs Checklist

  • Checked by AI
  • Test Cases Built

@DongLiang-0 DongLiang-0 changed the title fix the function of SHOW DELETE, SHOW FRONTEND CONFIG and SET FRONTEND CONFIG document fix the document of SHOW DELETE, SHOW FRONTEND CONFIG and SET FRONTEND CONFIG function Mar 14, 2025
```

## Optional Parameters
`fe_config_key` and `fe_config_value` can be viewed and modified by `SHOW FRONTEND CONFIG;` command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果是参考其他的语句,最好加上超链接

```

## Optional Parameters
`fe_config_key` and `fe_config_value` can be viewed and modified by `SHOW FRONTEND CONFIG;` command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 modified 怎么理解?show 应该只能查看不能修改?

ADMIN SET FRONTEND CONFIG ("key" = "value") [ALL];
-- or
ADMIN SET ALL FRONTENDS CONFIG ("key" = "value");
ADMIN SET [ALL FRONTENDS | FRONTEND] CONFIG ("<fe_config_key>" = "<fe_config_value>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ADMIN SET [ALL FRONTENDS | FRONTEND] CONFIG ("<fe_config_key>" = "<fe_config_value>")
ADMIN SET {ALL FRONTENDS | FRONTEND} CONFIG ("<fe_config_key>" = "<fe_config_value>")

ADMIN SET FRONTEND CONFIG ("key" = "value") [ALL];
-- or
ADMIN SET ALL FRONTENDS CONFIG ("key" = "value");
ADMIN SET [ALL FRONTENDS | FRONTEND] CONFIG ("<fe_config_key>" = "<fe_config_value>")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以一次修改多个配置吗?如果可以的话,需要这样

Suggested change
ADMIN SET [ALL FRONTENDS | FRONTEND] CONFIG ("<fe_config_key>" = "<fe_config_value>")
ADMIN SET [ALL FRONTENDS | FRONTEND] CONFIG ("<fe_config_key>" = "<fe_config_value>" [, ... ])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不能一次修改多个配置

```

## 可选参数
需要修改的 `<fe_config_key>`、`<fe_config_value>` 可通过 [SHOW FRONTEND CONFIG](./SHOW-FRONTEND-CONFIG) 命令查看
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要在必选参数中增加一个

*1. `{ALL FRONTENDS | FRONTEND}`*

解释 这两个分支语句 分别的作用

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@DongLiang-0
Copy link
Contributor Author

@morrySnow PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants