-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](index build) Correct inverted index behavior after dynamically adding a column #48389
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 31859 ms
|
TPC-DS: Total hot run time: 190583 ms
|
ClickBench: Total hot run time: 31.45 s
|
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
TPC-H: Total hot run time: 31552 ms
|
TPC-DS: Total hot run time: 191122 ms
|
ClickBench: Total hot run time: 31.19 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
TPC-H: Total hot run time: 31853 ms
|
TPC-DS: Total hot run time: 184337 ms
|
ClickBench: Total hot run time: 31.05 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
…adding a column (#48389) Problem Summary: This pull request includes changes to improve the handling of inverted indexes and to add new test cases for index changes on new columns. The most important changes include fixing the placement of inverted index writers, adding new test cases for inverted index changes, and modifying the test output file to reflect the new test cases.
…adding a column (#48389) Problem Summary: This pull request includes changes to improve the handling of inverted indexes and to add new test cases for index changes on new columns. The most important changes include fixing the placement of inverted index writers, adding new test cases for inverted index changes, and modifying the test output file to reflect the new test cases.
…dynamically adding a column #48389 (#48546) Cherry-picked from #48389 --------- Co-authored-by: airborne12 <[email protected]>
…adding a column (#48389) Problem Summary: This pull request includes changes to improve the handling of inverted indexes and to add new test cases for index changes on new columns. The most important changes include fixing the placement of inverted index writers, adding new test cases for inverted index changes, and modifying the test output file to reflect the new test cases.
…adding a column (#48389) Problem Summary: This pull request includes changes to improve the handling of inverted indexes and to add new test cases for index changes on new columns. The most important changes include fixing the placement of inverted index writers, adding new test cases for inverted index changes, and modifying the test output file to reflect the new test cases.
…adding a column (#48389) Problem Summary: This pull request includes changes to improve the handling of inverted indexes and to add new test cases for index changes on new columns. The most important changes include fixing the placement of inverted index writers, adding new test cases for inverted index changes, and modifying the test output file to reflect the new test cases.
…dynamically adding a column #48389 (#48547) Cherry-picked from #48389 Co-authored-by: airborne12 <[email protected]>
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
This pull request includes changes to improve the handling of inverted indexes and to add new test cases for index changes on new columns. The most important changes include fixing the placement of inverted index writers, adding new test cases for inverted index changes, and modifying the test output file to reflect the new test cases.
Improvements to inverted index handling:
be/src/olap/task/index_builder.cpp
: Moved the_inverted_index_file_writers
placement to ensure the original inverted index is not deleted prematurely.Enhancements to test cases:
regression-test/suites/inverted_index_p0/index_change/test_index_change_on_new_column.groovy
: Added new test cases to verify the behavior of inverted index changes on newly added columns.Updates to test output:
regression-test/data/inverted_index_p0/index_change/test_index_change_on_new_column.out
: Updated the test output file to include the results of the new test cases.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)