[fix](information_schema) The time type in tables under the information_schema should change according to the time_zone. #48462
+318
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
BePPPower
force-pushed
the
fixInformationSchemaTimeZone
branch
from
0cc598b to
cd89f61
Compare
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32070 ms |
TPC-DS: Total hot run time: 189999 ms |
ClickBench: Total hot run time: 31.43 s |
BePPPower
changed the title
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31505 ms |
TPC-DS: Total hot run time: 189980 ms |
ClickBench: Total hot run time: 31.24 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31829 ms |
TPC-DS: Total hot run time: 190562 ms |
ClickBench: Total hot run time: 31.36 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
reviewed
Mar 3, 2025
| @@ -49,6 +50,7 @@ class SchemaTablesScanner : public SchemaScanner { | |||
| TGetDbsResult _db_result; | |||
| TListTableStatusResult _table_result; | |||
| static std::vector<SchemaScanner::ColumnDesc> _s_tbls_columns; | |||
| cctz::time_zone _timezone_obj; | |||
There was a problem hiding this comment.
I think this member can be put in parent class SchemaScanner
and set it in _schema_scanner->init()
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 31921 ms |
TPC-DS: Total hot run time: 190960 ms |
ClickBench: Total hot run time: 31.46 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
TeamCity cloud ut coverage result: |
BePPPower
force-pushed
the
fixInformationSchemaTimeZone
branch
from
adbdfe8 to
cbfb0b1
Compare
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32903 ms |
TPC-DS: Total hot run time: 191661 ms |
ClickBench: Total hot run time: 31.17 s |
|
run external beut |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32650 ms |
TPC-DS: Total hot run time: 192619 ms |
ClickBench: Total hot run time: 31.46 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run p0 |
morningman
reviewed
Mar 7, 2025
| @@ -78,6 +78,7 @@ Status SchemaRowsetsScanner::start(RuntimeState* state) { | |||
| return Status::InternalError("used before initialized."); | |||
| } | |||
| backend_id_ = state->backend_id(); | |||
| _timezone_obj = state->timezone_obj(); | |||
There was a problem hiding this comment.
Move this set method in SchemaScanner::init
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32498 ms |
TPC-DS: Total hot run time: 185374 ms |
ClickBench: Total hot run time: 31.4 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Summary:
Fix the issue where the time type in tables under the information_schema does not change with the
time_zonesession variable.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)