Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](group commit) add some log to unstable insert_group_commit_with_prepare_stmt case #48470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Feb 28, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Feb 28, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31777 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5dd53194ba0a603800a7f1530d71d8003a3d7b2a, data reload: false

------ Round 1 ----------------------------------
q1	17601	5212	5133	5133
q2	2053	312	167	167
q3	10495	1305	743	743
q4	10244	1050	548	548
q5	7669	2367	2407	2367
q6	185	169	133	133
q7	928	765	599	599
q8	9293	1285	1117	1117
q9	4908	4640	4881	4640
q10	6838	2320	1907	1907
q11	479	274	259	259
q12	341	346	216	216
q13	17794	3697	3108	3108
q14	226	229	218	218
q15	511	472	463	463
q16	647	638	588	588
q17	569	908	369	369
q18	6585	6179	6276	6179
q19	1740	978	545	545
q20	315	323	188	188
q21	2767	2134	1983	1983
q22	381	333	307	307
Total cold run time: 102569 ms
Total hot run time: 31777 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5199	5129	5183	5129
q2	238	335	231	231
q3	2176	2671	2266	2266
q4	1454	1855	1388	1388
q5	4292	4157	4151	4151
q6	214	165	123	123
q7	1856	1821	1737	1737
q8	2611	2688	2575	2575
q9	7287	7223	7220	7220
q10	3074	3233	2817	2817
q11	585	501	507	501
q12	706	797	628	628
q13	3383	3966	3310	3310
q14	290	312	273	273
q15	518	478	462	462
q16	665	707	654	654
q17	1142	1540	1399	1399
q18	7569	7399	7233	7233
q19	797	830	901	830
q20	2021	2062	1884	1884
q21	5461	5064	4753	4753
q22	618	574	579	574
Total cold run time: 52156 ms
Total hot run time: 50138 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190793 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5dd53194ba0a603800a7f1530d71d8003a3d7b2a, data reload: false

query1	1328	979	932	932
query2	6358	1895	1853	1853
query3	11113	4584	4614	4584
query4	57154	24165	23208	23208
query5	4875	515	499	499
query6	327	184	176	176
query7	4899	511	289	289
query8	289	232	220	220
query9	5425	2595	2603	2595
query10	430	317	262	262
query11	15108	15048	14779	14779
query12	153	111	106	106
query13	1034	517	388	388
query14	10805	6574	6681	6574
query15	217	205	181	181
query16	7239	635	495	495
query17	1101	740	623	623
query18	1657	412	304	304
query19	195	193	158	158
query20	132	134	116	116
query21	205	121	105	105
query22	4638	4679	4396	4396
query23	34144	33456	33306	33306
query24	5707	2425	2456	2425
query25	487	487	410	410
query26	686	277	153	153
query27	1741	486	337	337
query28	2739	2472	2439	2439
query29	567	561	427	427
query30	211	191	160	160
query31	870	867	800	800
query32	72	64	65	64
query33	437	353	345	345
query34	767	900	494	494
query35	791	847	777	777
query36	963	975	925	925
query37	124	116	75	75
query38	4206	4169	4283	4169
query39	1483	1436	1420	1420
query40	204	120	103	103
query41	51	50	49	49
query42	132	105	106	105
query43	510	518	485	485
query44	1291	816	806	806
query45	180	172	167	167
query46	889	1091	672	672
query47	1862	1908	1809	1809
query48	390	409	334	334
query49	676	535	423	423
query50	701	758	433	433
query51	4292	4215	4227	4215
query52	110	105	97	97
query53	237	259	191	191
query54	487	510	433	433
query55	86	76	81	76
query56	284	288	261	261
query57	1185	1208	1141	1141
query58	248	251	237	237
query59	2933	2817	2761	2761
query60	320	286	266	266
query61	120	117	117	117
query62	753	741	664	664
query63	236	199	184	184
query64	1755	1034	733	733
query65	3282	3167	3143	3143
query66	683	388	297	297
query67	15825	15543	15264	15264
query68	5955	823	514	514
query69	533	295	254	254
query70	1188	1136	1103	1103
query71	474	297	261	261
query72	5807	3655	3774	3655
query73	1371	750	340	340
query74	9107	9427	8943	8943
query75	3491	3211	2692	2692
query76	3732	1183	752	752
query77	540	359	289	289
query78	9972	9940	9253	9253
query79	2455	827	575	575
query80	637	517	437	437
query81	494	281	238	238
query82	600	125	94	94
query83	187	171	156	156
query84	293	92	72	72
query85	828	418	382	382
query86	429	293	285	285
query87	4360	4415	4384	4384
query88	3522	2198	2246	2198
query89	406	323	288	288
query90	1874	195	198	195
query91	134	139	108	108
query92	77	54	62	54
query93	1857	1021	578	578
query94	663	431	300	300
query95	352	273	260	260
query96	480	566	265	265
query97	3345	3414	3315	3315
query98	227	204	202	202
query99	1434	1404	1316	1316
Total cold run time: 297223 ms
Total hot run time: 190793 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5dd53194ba0a603800a7f1530d71d8003a3d7b2a, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.04
query3	0.24	0.07	0.08
query4	1.60	0.10	0.10
query5	0.54	0.55	0.55
query6	1.18	0.73	0.73
query7	0.03	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.55	0.51
query10	0.56	0.59	0.56
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.61	0.59
query14	2.81	2.79	2.78
query15	0.93	0.86	0.84
query16	0.39	0.38	0.39
query17	1.02	1.06	1.01
query18	0.22	0.19	0.19
query19	1.94	1.88	1.96
query20	0.02	0.01	0.02
query21	15.36	0.89	0.53
query22	0.75	1.27	0.74
query23	14.79	1.37	0.63
query24	7.08	1.48	1.03
query25	0.50	0.13	0.27
query26	0.48	0.16	0.15
query27	0.06	0.05	0.05
query28	10.39	0.85	0.42
query29	12.56	3.94	3.26
query30	0.25	0.10	0.06
query31	2.81	0.57	0.39
query32	3.23	0.56	0.47
query33	3.02	3.01	3.07
query34	15.85	5.21	4.52
query35	4.56	4.58	4.59
query36	0.66	0.50	0.50
query37	0.10	0.06	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.18	0.14	0.12
query41	0.09	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.02 s
Total hot run time: 31.3 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.97% (12001/26685)
Line Coverage 34.47% (100843/292537)
Region Coverage 33.64% (51642/153496)
Branch Coverage 29.40% (26119/88838)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants