-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature](inverted index) Add a basic tokenizer #48716
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
47045de
to
4aa64a1
Compare
run buildall |
TPC-H: Total hot run time: 32726 ms
|
TPC-DS: Total hot run time: 183751 ms
|
ClickBench: Total hot run time: 30.9 s
|
run buildall |
TPC-H: Total hot run time: 32754 ms
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 192133 ms
|
ClickBench: Total hot run time: 30.63 s
|
run buildall |
TPC-H: Total hot run time: 32783 ms
|
TPC-DS: Total hot run time: 185819 ms
|
ClickBench: Total hot run time: 31.36 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
be/src/olap/inverted_index_parser.h
Outdated
@@ -69,6 +70,7 @@ const std::string INVERTED_INDEX_PARSER_UNICODE = "unicode"; | |||
const std::string INVERTED_INDEX_PARSER_ENGLISH = "english"; | |||
const std::string INVERTED_INDEX_PARSER_CHINESE = "chinese"; | |||
const std::string INVERTED_INDEX_PARSER_ICU = "icu"; | |||
const std::string INVERTED_INDEX_PARSER_SIMPLE = "simple"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
simple is not actually a good name for user to understand, maybe basic unicode or something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to basic
run buildall |
TPC-H: Total hot run time: 32753 ms
|
TPC-DS: Total hot run time: 185850 ms
|
ClickBench: Total hot run time: 30.85 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
run buildall |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)