-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat](binlog) Add config to control whether enable persistent connec… #48761
Open
w41ter
wants to merge
1
commit into
apache:master
Choose a base branch
from
w41ter:config_ingest_binlog_persistent_connections
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[feat](binlog) Add config to control whether enable persistent connec… #48761
w41ter
wants to merge
1
commit into
apache:master
from
w41ter:config_ingest_binlog_persistent_connections
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion during ingesting
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
wyxxxcat
approved these changes
Mar 7, 2025
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32838 ms
|
TPC-DS: Total hot run time: 191703 ms
|
ClickBench: Total hot run time: 31.05 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion during ingesting
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
In the previous PR #48467, a thread_local http connection is added to save the reconnect latency. However during the mixed workloads (both stream load and downloading binlog), the persistent connection will be blocked by the stream loading, which causes a latency spike.
The ingest latency with a persistent connection:

The ingest latency without persistent connection:
This PR makes a persistent connection for each ingesting task, and adding a config
enable_ingest_binlog_with_persistent_connection
to control whether to use the persistent connection. The config is disabled by default, and users who need to download binlogs over long distances can enable it to reduce the sync latency.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)