-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[feat](binlog) Add config to control whether enable persistent connec… #48761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat](binlog) Add config to control whether enable persistent connec… #48761
Conversation
…tion during ingesting
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 32838 ms
|
TPC-DS: Total hot run time: 191703 ms
|
ClickBench: Total hot run time: 31.05 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
apache#48761) …tion during ingesting
apache#48761) …tion during ingesting
apache#48761) …tion during ingesting
apache#48761) …tion during ingesting
apache#48761) …tion during ingesting
…tion during ingesting
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
In the previous PR #48467, a thread_local http connection is added to save the reconnect latency. However during the mixed workloads (both stream load and downloading binlog), the persistent connection will be blocked by the stream loading, which causes a latency spike.
The ingest latency with a persistent connection:

The ingest latency without persistent connection:
This PR makes a persistent connection for each ingesting task, and adding a config
enable_ingest_binlog_with_persistent_connection
to control whether to use the persistent connection. The config is disabled by default, and users who need to download binlogs over long distances can enable it to reduce the sync latency.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)