Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](statistics)The column name should be case sensitive when inject column stats. #48812

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jibing-Li
Copy link
Contributor

What problem does this PR solve?

Fix inject column stats column name case insensitive bug. The column name should be case sensitive when inject column stats, otherwise it couldn't be load to the cache.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review March 7, 2025 06:29
@Jibing-Li
Copy link
Contributor Author

run buildall

1 similar comment
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33591 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 89a85b2a64782a010e83a80c20c9d3e3de234361, data reload: false

------ Round 1 ----------------------------------
q1	17625	5214	5247	5214
q2	2051	309	170	170
q3	10653	1262	765	765
q4	10275	1027	542	542
q5	8532	2425	2325	2325
q6	195	167	135	135
q7	919	738	622	622
q8	9295	1265	1069	1069
q9	4971	4918	4888	4888
q10	6824	2336	1920	1920
q11	487	281	259	259
q12	360	354	222	222
q13	18988	3733	3121	3121
q14	230	219	201	201
q15	532	490	478	478
q16	618	611	597	597
q17	579	845	366	366
q18	6830	7107	6834	6834
q19	3593	988	567	567
q20	356	318	243	243
q21	3011	2345	1976	1976
q22	1204	1119	1077	1077
Total cold run time: 108128 ms
Total hot run time: 33591 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5323	5245	5158	5158
q2	238	335	233	233
q3	2178	2713	2314	2314
q4	1478	1818	1371	1371
q5	4253	4153	4342	4153
q6	216	166	127	127
q7	1986	1954	1758	1758
q8	2596	2696	2578	2578
q9	7148	7099	7204	7099
q10	3020	3123	2700	2700
q11	595	525	484	484
q12	709	763	637	637
q13	3481	3886	3335	3335
q14	282	296	267	267
q15	509	506	486	486
q16	661	681	639	639
q17	1158	1561	1362	1362
q18	7729	7617	7486	7486
q19	806	798	876	798
q20	1984	2047	1896	1896
q21	5293	4845	4785	4785
q22	1115	1099	1068	1068
Total cold run time: 52758 ms
Total hot run time: 50734 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191387 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 89a85b2a64782a010e83a80c20c9d3e3de234361, data reload: false

query1	1388	1014	965	965
query2	6264	1906	1886	1886
query3	11105	4524	4748	4524
query4	25941	23409	23176	23176
query5	4374	654	492	492
query6	319	205	194	194
query7	3998	489	295	295
query8	295	248	240	240
query9	8517	2512	2516	2512
query10	480	304	262	262
query11	15382	15069	14872	14872
query12	162	109	112	109
query13	1562	508	385	385
query14	10647	6388	6700	6388
query15	210	187	192	187
query16	7625	673	478	478
query17	1580	770	567	567
query18	2070	435	301	301
query19	193	182	159	159
query20	137	118	126	118
query21	202	120	107	107
query22	4493	4482	4395	4395
query23	33866	33617	33264	33264
query24	7192	2453	2475	2453
query25	521	469	415	415
query26	1348	287	160	160
query27	2133	505	338	338
query28	3994	2404	2427	2404
query29	695	556	449	449
query30	284	222	197	197
query31	942	877	822	822
query32	71	66	61	61
query33	574	359	304	304
query34	891	888	526	526
query35	807	885	818	818
query36	994	1035	915	915
query37	127	116	86	86
query38	4297	4299	4212	4212
query39	1503	1422	1414	1414
query40	215	130	105	105
query41	52	52	55	52
query42	122	114	109	109
query43	497	514	492	492
query44	1343	836	811	811
query45	182	187	180	180
query46	883	1030	685	685
query47	1807	1883	1811	1811
query48	396	465	306	306
query49	791	524	429	429
query50	692	744	422	422
query51	4247	4334	4251	4251
query52	111	107	92	92
query53	232	259	201	201
query54	510	506	420	420
query55	83	83	80	80
query56	257	276	247	247
query57	1179	1173	1069	1069
query58	253	240	248	240
query59	2645	2920	2822	2822
query60	284	272	269	269
query61	119	115	119	115
query62	783	751	689	689
query63	226	194	191	191
query64	4098	1050	683	683
query65	4565	4428	4456	4428
query66	978	392	296	296
query67	16460	15514	15253	15253
query68	8096	873	510	510
query69	461	302	259	259
query70	1192	1150	1103	1103
query71	420	291	260	260
query72	5101	3502	3710	3502
query73	1149	725	347	347
query74	9069	9137	8653	8653
query75	3969	3166	2714	2714
query76	4735	1219	757	757
query77	941	368	277	277
query78	9833	10075	9308	9308
query79	3832	839	568	568
query80	611	516	440	440
query81	457	250	221	221
query82	438	132	94	94
query83	170	168	151	151
query84	291	100	73	73
query85	750	432	302	302
query86	326	320	272	272
query87	4484	4625	4405	4405
query88	2918	2227	2191	2191
query89	418	311	272	272
query90	2121	218	219	218
query91	138	149	108	108
query92	78	58	57	57
query93	1949	1045	582	582
query94	686	404	296	296
query95	346	268	255	255
query96	494	553	274	274
query97	3302	3419	3274	3274
query98	221	211	203	203
query99	1371	1500	1243	1243
Total cold run time: 281560 ms
Total hot run time: 191387 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 89a85b2a64782a010e83a80c20c9d3e3de234361, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.06	0.06
query4	1.63	0.11	0.11
query5	0.55	0.53	0.53
query6	1.19	0.72	0.71
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.53	0.51
query10	0.57	0.61	0.58
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.61	0.60
query14	2.82	2.70	2.73
query15	0.93	0.84	0.84
query16	0.38	0.37	0.37
query17	0.99	1.02	1.03
query18	0.21	0.19	0.20
query19	1.91	1.75	1.95
query20	0.02	0.02	0.01
query21	15.36	0.88	0.54
query22	0.74	1.34	0.72
query23	14.75	1.34	0.61
query24	7.37	1.51	1.49
query25	0.48	0.19	0.14
query26	0.58	0.17	0.13
query27	0.04	0.04	0.04
query28	10.12	0.81	0.41
query29	12.52	3.97	3.29
query30	0.25	0.09	0.06
query31	2.82	0.59	0.38
query32	3.23	0.55	0.45
query33	2.96	3.05	3.06
query34	15.64	5.18	4.52
query35	4.51	4.57	4.54
query36	0.66	0.50	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.07	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.63 s
Total hot run time: 31.5 s

@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32458 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a600ae63204ddfed7208fd6a9a38f8627c928a54, data reload: false

------ Round 1 ----------------------------------
q1	17614	5195	5112	5112
q2	2071	292	168	168
q3	10411	1269	708	708
q4	10201	1037	541	541
q5	7517	2402	2423	2402
q6	190	170	133	133
q7	902	734	613	613
q8	9309	1301	1094	1094
q9	4935	4717	4506	4506
q10	6821	2311	1892	1892
q11	480	283	258	258
q12	346	353	221	221
q13	17786	3680	3083	3083
q14	219	225	200	200
q15	538	494	484	484
q16	634	621	585	585
q17	587	858	349	349
q18	6771	6477	6382	6382
q19	1087	959	550	550
q20	320	316	206	206
q21	2810	2141	2006	2006
q22	1030	1020	965	965
Total cold run time: 102579 ms
Total hot run time: 32458 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5172	5162	5187	5162
q2	238	322	229	229
q3	2136	2680	2334	2334
q4	1398	1808	1342	1342
q5	4293	4160	4185	4160
q6	212	162	122	122
q7	1849	1843	1769	1769
q8	2623	2585	2593	2585
q9	7356	7278	7119	7119
q10	2993	3191	2793	2793
q11	567	508	502	502
q12	692	756	604	604
q13	3521	3863	3231	3231
q14	277	284	270	270
q15	525	485	493	485
q16	664	711	640	640
q17	1149	1622	1334	1334
q18	7724	7679	7408	7408
q19	837	845	891	845
q20	1991	1984	1930	1930
q21	5303	4967	4842	4842
q22	1091	1083	1055	1055
Total cold run time: 52611 ms
Total hot run time: 50761 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185561 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a600ae63204ddfed7208fd6a9a38f8627c928a54, data reload: false

query1	981	396	383	383
query2	6527	1914	1941	1914
query3	6795	227	217	217
query4	26376	23390	23475	23390
query5	4331	651	489	489
query6	298	201	184	184
query7	4603	508	295	295
query8	297	243	230	230
query9	8595	2518	2514	2514
query10	442	305	276	276
query11	15504	15144	15046	15046
query12	156	113	106	106
query13	1647	505	418	418
query14	9270	6086	6164	6086
query15	216	186	170	170
query16	7228	641	439	439
query17	1213	750	577	577
query18	1961	421	301	301
query19	198	188	174	174
query20	125	117	115	115
query21	208	126	105	105
query22	4034	4239	4150	4150
query23	34089	32848	33019	32848
query24	8447	2411	2446	2411
query25	576	498	418	418
query26	1245	278	162	162
query27	2724	505	335	335
query28	4369	2411	2382	2382
query29	776	575	442	442
query30	293	217	194	194
query31	947	871	782	782
query32	77	126	63	63
query33	569	361	292	292
query34	772	866	501	501
query35	800	837	747	747
query36	962	1026	881	881
query37	117	97	77	77
query38	4140	4211	4214	4211
query39	1454	1385	1385	1385
query40	206	115	106	106
query41	54	55	52	52
query42	129	102	103	102
query43	489	516	495	495
query44	1282	777	779	777
query45	179	171	163	163
query46	851	1026	631	631
query47	1733	1763	1699	1699
query48	364	399	289	289
query49	802	499	429	429
query50	685	741	403	403
query51	4148	4169	4089	4089
query52	109	104	100	100
query53	228	252	185	185
query54	486	488	423	423
query55	85	81	78	78
query56	288	270	252	252
query57	1115	1128	1073	1073
query58	243	239	236	236
query59	2498	2809	2534	2534
query60	310	263	271	263
query61	130	120	123	120
query62	783	735	658	658
query63	250	190	186	186
query64	4347	1021	665	665
query65	4427	4335	4323	4323
query66	1132	407	313	313
query67	15734	15469	15224	15224
query68	8483	867	506	506
query69	456	293	271	271
query70	1185	1151	1123	1123
query71	490	297	270	270
query72	5794	3625	3752	3625
query73	794	731	339	339
query74	9217	9115	9063	9063
query75	3881	3143	2701	2701
query76	3642	1177	747	747
query77	785	369	283	283
query78	10084	10203	9285	9285
query79	1948	825	592	592
query80	632	516	460	460
query81	466	259	221	221
query82	452	129	96	96
query83	212	176	154	154
query84	287	95	82	82
query85	773	355	332	332
query86	336	315	271	271
query87	4548	4623	4482	4482
query88	2822	2193	2274	2193
query89	394	313	295	295
query90	1910	212	208	208
query91	137	142	112	112
query92	70	61	59	59
query93	1177	1075	588	588
query94	666	409	308	308
query95	350	276	253	253
query96	489	561	275	275
query97	3421	3394	3311	3311
query98	224	210	201	201
query99	1489	1410	1277	1277
Total cold run time: 274063 ms
Total hot run time: 185561 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.86 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a600ae63204ddfed7208fd6a9a38f8627c928a54, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.07
query4	1.62	0.10	0.11
query5	0.56	0.54	0.55
query6	1.21	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.61	0.52	0.52
query10	0.59	0.58	0.59
query11	0.15	0.12	0.11
query12	0.14	0.11	0.10
query13	0.61	0.62	0.60
query14	2.71	2.76	2.86
query15	0.90	0.84	0.85
query16	0.37	0.39	0.37
query17	1.03	1.02	1.03
query18	0.22	0.20	0.19
query19	1.93	1.84	1.99
query20	0.02	0.01	0.01
query21	15.36	0.89	0.54
query22	0.74	1.14	0.65
query23	15.03	1.35	0.63
query24	7.56	1.46	0.90
query25	0.54	0.20	0.06
query26	0.50	0.17	0.14
query27	0.06	0.05	0.05
query28	9.64	0.79	0.42
query29	12.57	3.97	3.34
query30	0.26	0.09	0.06
query31	2.82	0.58	0.39
query32	3.22	0.55	0.46
query33	2.97	2.99	3.05
query34	15.88	5.12	4.47
query35	4.50	4.50	4.54
query36	0.66	0.49	0.50
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.87 s
Total hot run time: 30.86 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants