Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](mtmv)fix mtmv may have repeat tasks after canceled #48830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zddr
Copy link
Contributor

@zddr zddr commented Mar 7, 2025

What problem does this PR solve?

fix mtmv may have repeat tasks after canceled
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
fix mtmv may have repeat tasks after canceled

Release note

fix mtmv may have repeat tasks after canceled

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Mar 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32760 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1d654aff2d36ec42366c11564c7a59a15b1d5379, data reload: false

------ Round 1 ----------------------------------
q1	17588	5312	5182	5182
q2	2050	305	168	168
q3	10409	1341	730	730
q4	10229	1018	540	540
q5	7558	2401	2359	2359
q6	190	170	136	136
q7	929	749	604	604
q8	9333	1254	1123	1123
q9	5547	4846	4629	4629
q10	6838	2318	1904	1904
q11	499	268	263	263
q12	348	350	212	212
q13	17782	3672	3128	3128
q14	223	222	214	214
q15	526	481	488	481
q16	645	614	571	571
q17	585	869	348	348
q18	6781	6546	6477	6477
q19	1207	954	541	541
q20	326	331	196	196
q21	2969	2092	1952	1952
q22	1059	1015	1002	1002
Total cold run time: 103621 ms
Total hot run time: 32760 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5217	5236	5232	5232
q2	247	333	234	234
q3	2190	2668	2330	2330
q4	1459	1840	1382	1382
q5	4265	4144	4176	4144
q6	208	161	126	126
q7	1939	1957	1747	1747
q8	2681	2574	2559	2559
q9	7279	7213	7161	7161
q10	3006	3175	2756	2756
q11	584	511	503	503
q12	690	771	621	621
q13	3553	3925	3228	3228
q14	301	281	280	280
q15	520	471	492	471
q16	655	675	631	631
q17	1143	1599	1346	1346
q18	7832	7520	7461	7461
q19	824	867	931	867
q20	2010	2012	1890	1890
q21	5452	5063	4880	4880
q22	1135	1071	1052	1052
Total cold run time: 53190 ms
Total hot run time: 50901 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185441 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1d654aff2d36ec42366c11564c7a59a15b1d5379, data reload: false

query1	992	407	389	389
query2	6538	1913	1922	1913
query3	6810	223	221	221
query4	26669	23925	23096	23096
query5	4340	671	517	517
query6	307	205	199	199
query7	4611	501	297	297
query8	303	251	238	238
query9	8590	2522	2517	2517
query10	466	325	270	270
query11	15920	15101	15032	15032
query12	163	109	106	106
query13	1647	515	397	397
query14	9734	6497	6488	6488
query15	219	182	179	179
query16	7311	643	451	451
query17	1180	707	538	538
query18	1757	390	291	291
query19	190	178	152	152
query20	126	115	115	115
query21	216	120	99	99
query22	4201	4194	3974	3974
query23	34111	33084	32896	32896
query24	8185	2452	2448	2448
query25	518	487	407	407
query26	1240	269	161	161
query27	2666	493	331	331
query28	4302	2401	2367	2367
query29	715	569	426	426
query30	288	223	194	194
query31	960	849	775	775
query32	82	66	68	66
query33	560	369	311	311
query34	770	860	498	498
query35	799	831	753	753
query36	991	1002	887	887
query37	125	99	80	80
query38	4210	4266	4082	4082
query39	1436	1419	1455	1419
query40	219	123	110	110
query41	59	56	62	56
query42	126	106	107	106
query43	503	506	475	475
query44	1301	797	789	789
query45	179	185	172	172
query46	836	1027	644	644
query47	1733	1767	1714	1714
query48	387	422	306	306
query49	813	551	469	469
query50	702	736	417	417
query51	4186	4196	4156	4156
query52	108	111	95	95
query53	236	265	186	186
query54	498	496	421	421
query55	84	81	83	81
query56	269	276	249	249
query57	1086	1150	1063	1063
query58	245	232	234	232
query59	2578	2771	2551	2551
query60	311	321	257	257
query61	124	117	120	117
query62	802	717	674	674
query63	237	187	184	184
query64	4322	1021	676	676
query65	4407	4382	4354	4354
query66	1095	412	316	316
query67	15560	15506	15251	15251
query68	9225	888	513	513
query69	462	303	267	267
query70	1182	1131	1114	1114
query71	493	307	277	277
query72	5279	3685	3800	3685
query73	785	726	341	341
query74	8974	9185	8744	8744
query75	4278	3170	2750	2750
query76	3999	1200	752	752
query77	949	418	286	286
query78	10203	10185	9343	9343
query79	2752	856	606	606
query80	690	580	460	460
query81	470	262	224	224
query82	575	129	103	103
query83	215	180	160	160
query84	300	100	75	75
query85	769	358	313	313
query86	342	285	298	285
query87	4633	4449	4335	4335
query88	2927	2228	2253	2228
query89	436	317	288	288
query90	1976	222	217	217
query91	145	135	109	109
query92	75	65	59	59
query93	1950	1087	595	595
query94	682	411	306	306
query95	364	279	269	269
query96	501	571	278	278
query97	3445	3456	3280	3280
query98	224	204	203	203
query99	1460	1407	1275	1275
Total cold run time: 278014 ms
Total hot run time: 185441 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1d654aff2d36ec42366c11564c7a59a15b1d5379, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.03
query3	0.23	0.07	0.06
query4	1.61	0.10	0.11
query5	0.56	0.56	0.54
query6	1.17	0.73	0.74
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.59	0.51	0.52
query10	0.58	0.62	0.58
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.63	0.62	0.61
query14	2.79	2.85	2.68
query15	0.93	0.86	0.86
query16	0.37	0.39	0.38
query17	1.04	1.03	1.00
query18	0.22	0.20	0.20
query19	1.90	2.03	1.79
query20	0.01	0.01	0.01
query21	15.38	0.90	0.53
query22	0.76	1.24	0.72
query23	14.82	1.37	0.67
query24	6.77	2.24	1.02
query25	0.49	0.26	0.20
query26	0.59	0.16	0.15
query27	0.05	0.05	0.05
query28	10.34	0.82	0.44
query29	12.55	4.02	3.30
query30	0.26	0.09	0.07
query31	2.82	0.62	0.39
query32	3.23	0.56	0.46
query33	3.02	3.02	3.02
query34	15.71	5.13	4.59
query35	4.60	4.56	4.61
query36	0.65	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.65 s
Total hot run time: 31.36 s

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what will happen if status changed after if statement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants