Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [refactor](execenv) remove shared ptr from exec env #46034 #48832

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

zhiqiang-hhhh
Copy link
Contributor

cherry pick from #46034

ExecEnv should be the last object to deconstructed, so that it should
not own any shared ptr. If it own any shared ptr, then we could not make
sure the deconstruct sequence.
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Mar 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 40288 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b3c7f8846e7338f0969f82a9ab3a23a76a86d2f8, data reload: false

------ Round 1 ----------------------------------
q1	17583	6685	6620	6620
q2	2058	171	183	171
q3	10593	1099	1194	1099
q4	10536	740	738	738
q5	7736	2917	2850	2850
q6	223	134	136	134
q7	986	617	605	605
q8	9378	1977	2061	1977
q9	6679	6458	6417	6417
q10	6998	2258	2327	2258
q11	481	273	258	258
q12	401	213	210	210
q13	17792	2982	3000	2982
q14	242	209	219	209
q15	504	477	462	462
q16	660	599	584	584
q17	975	598	620	598
q18	7371	6835	6615	6615
q19	1380	1087	1031	1031
q20	500	207	199	199
q21	4033	3317	3272	3272
q22	1128	999	1018	999
Total cold run time: 108237 ms
Total hot run time: 40288 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6578	6540	6595	6540
q2	336	231	228	228
q3	2978	2785	2952	2785
q4	2041	1779	1791	1779
q5	5817	5718	5742	5718
q6	212	127	129	127
q7	2252	1809	1786	1786
q8	3390	3558	3522	3522
q9	8934	8823	8868	8823
q10	3574	3538	3521	3521
q11	597	484	489	484
q12	828	633	616	616
q13	8962	3200	3208	3200
q14	303	275	289	275
q15	517	471	461	461
q16	716	652	671	652
q17	1866	1664	1630	1630
q18	8297	7852	7663	7663
q19	1655	1621	1596	1596
q20	2098	1874	1894	1874
q21	5658	5441	5275	5275
q22	1128	1100	1029	1029
Total cold run time: 68737 ms
Total hot run time: 59584 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197723 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b3c7f8846e7338f0969f82a9ab3a23a76a86d2f8, data reload: false

query1	1288	901	913	901
query2	6243	2136	2103	2103
query3	10944	4504	4566	4504
query4	61590	29166	22966	22966
query5	5244	458	441	441
query6	396	178	170	170
query7	5494	312	301	301
query8	307	230	224	224
query9	8637	2652	2610	2610
query10	466	262	250	250
query11	17528	15223	15749	15223
query12	159	104	108	104
query13	1434	462	426	426
query14	10346	7221	7520	7221
query15	202	189	178	178
query16	7078	490	516	490
query17	1179	605	595	595
query18	1879	321	305	305
query19	208	165	161	161
query20	119	114	111	111
query21	202	101	106	101
query22	4980	4978	4683	4683
query23	35000	34083	34299	34083
query24	6115	2898	2953	2898
query25	547	432	422	422
query26	666	172	165	165
query27	1932	371	358	358
query28	4242	2479	2461	2461
query29	718	475	437	437
query30	251	169	171	169
query31	997	839	846	839
query32	66	55	57	55
query33	393	297	294	294
query34	915	512	533	512
query35	871	728	732	728
query36	1102	962	966	962
query37	114	69	74	69
query38	4168	4047	3989	3989
query39	1516	1456	1447	1447
query40	203	96	96	96
query41	49	47	49	47
query42	117	118	100	100
query43	558	508	512	508
query44	1168	831	841	831
query45	183	176	170	170
query46	1155	733	734	733
query47	2044	1902	2001	1902
query48	487	376	398	376
query49	743	409	408	408
query50	842	434	422	422
query51	7400	7207	7190	7190
query52	109	86	90	86
query53	261	189	188	188
query54	593	463	472	463
query55	79	87	78	78
query56	262	259	260	259
query57	1307	1147	1139	1139
query58	235	203	204	203
query59	3078	2970	2996	2970
query60	266	246	246	246
query61	110	135	107	107
query62	755	654	651	651
query63	219	193	192	192
query64	1372	678	649	649
query65	3284	3180	3188	3180
query66	682	294	329	294
query67	16013	15815	15646	15646
query68	4174	604	582	582
query69	426	266	262	262
query70	1181	1149	1052	1052
query71	344	256	259	256
query72	6087	4185	4039	4039
query73	758	355	354	354
query74	10551	9111	9146	9111
query75	3336	2661	2643	2643
query76	1943	1011	1000	1000
query77	540	275	282	275
query78	10595	9635	9589	9589
query79	1093	596	598	596
query80	816	430	430	430
query81	516	244	238	238
query82	1287	90	88	88
query83	242	151	147	147
query84	289	84	85	84
query85	883	300	298	298
query86	311	290	298	290
query87	4371	4263	4378	4263
query88	3518	2375	2352	2352
query89	422	298	287	287
query90	2021	180	199	180
query91	183	149	151	149
query92	58	48	48	48
query93	1219	545	545	545
query94	732	294	292	292
query95	358	258	251	251
query96	606	287	281	281
query97	3331	3175	3174	3174
query98	207	203	193	193
query99	1518	1284	1299	1284
Total cold run time: 313026 ms
Total hot run time: 197723 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.44 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b3c7f8846e7338f0969f82a9ab3a23a76a86d2f8, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.52	0.50	0.50
query6	1.13	0.75	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.57	0.51	0.49
query10	0.54	0.56	0.55
query11	0.14	0.10	0.10
query12	0.15	0.10	0.11
query13	0.61	0.60	0.61
query14	2.81	2.72	2.77
query15	0.89	0.83	0.83
query16	0.38	0.37	0.40
query17	1.05	1.03	1.02
query18	0.23	0.22	0.22
query19	1.96	1.79	2.04
query20	0.01	0.00	0.01
query21	15.35	0.62	0.60
query22	2.32	2.18	2.22
query23	16.88	0.97	0.90
query24	3.08	1.56	0.86
query25	0.20	0.07	0.06
query26	0.60	0.13	0.13
query27	0.06	0.04	0.03
query28	10.16	0.47	0.45
query29	12.57	3.27	3.28
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.23	0.46	0.45
query33	3.01	2.98	3.07
query34	17.35	4.49	4.51
query35	4.54	4.58	4.53
query36	0.67	0.49	0.48
query37	0.10	0.06	0.05
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.14
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.62 s
Total hot run time: 32.44 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants