[feature](function) support add/sub_time functions #56200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 1483 ms |
TPC-DS: Total hot run time: 2725 ms |
ClickBench: Total hot run time: 0.03 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
8 tasks
|
run buildall |
TPC-H: Total hot run time: 1533 ms |
TPC-DS: Total hot run time: 2806 ms |
ClickBench: Total hot run time: 0.09 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
zclllyybb
reviewed
Sep 22, 2025
| }; | ||
|
|
||
| template <PrimitiveType PType, typename Impl> | ||
| struct TimeComputeImpl { |
There was a problem hiding this comment.
两个模板参数继承不了虚函数create
| DateV2Value<DateTimeV2ValueType> dtv1 = | ||
| binary_cast<InputType1, DateV2Value<DateTimeV2ValueType>>(arg1); | ||
| auto tv2 = static_cast<TimeValue::TimeType>(arg2); | ||
| bool neg = std::string_view(name) == "sub_time"; |
| double res = TimeValue::limit_with_bound(neg ? tv1 - tv2 : tv1 + tv2); | ||
| return res; | ||
| } else { | ||
| throw Exception(ErrorCode::INVALID_ARGUMENT, "not support type for function {}", name); |
There was a problem hiding this comment.
走到这说明FE和BE没对上，是INTERNAL_ERROR。INVALID_ARGUMENT代表用户输入能够造成的问题
| res_data[i] = transform.execute(left_value, right_col[i]); | ||
| } | ||
| } | ||
| void execute_constant_constant(const NativeType1 left_value, const NativeType2 right_value, |
There was a problem hiding this comment.
再测一下两个参数都带精度，精度不同的情况，分别在FE和BE执行，确认规划正常。
| ComputeSignatureForDateArithmetic, PropagateNullable, DateAddSubMonotonic { | ||
|
|
||
| private static final List<FunctionSignature> SIGNATURES = ImmutableList.of( | ||
| FunctionSignature.ret(DateTimeV2Type.SYSTEM_DEFAULT).args(DateTimeV2Type.SYSTEM_DEFAULT, |
There was a problem hiding this comment.
得同时兼容两种格式，参照ComputeSignatureForDateArithmetic实现一个ComputeSignatureForTimeArithmetic吧，这个顺序不变，但literal情况优先匹配到timev2。
| using NativeType2 = typename Transform::InputType2; | ||
| using ReturnNativeType = typename Transform::ReturnNativeType; | ||
| static constexpr auto name = Transform::name; | ||
| static constexpr bool has_variadic_argument = |
There was a problem hiding this comment.
这里不用这些判断，这个基模板的实现模板是固定的，has_variadic_argument就是true。
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
dwdwqfwe
force-pushed
the
support_add_time
branch
from
78feeaf to
353f2ac
Compare
|
run buildall |
ClickBench: Total hot run time: 30.19 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run p0 |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
zclllyybb
reviewed
Sep 26, 2025
| * <p> | ||
| * Note: Please ensure that this class only has some lists and no procedural code. | ||
| * Note: Please ensure that this class only has some lists and no procedural | ||
| * code. |
There was a problem hiding this comment.
dont format irrelative code
| } else if constexpr (PType == TYPE_TIMEV2) { | ||
| auto tv1 = static_cast<TimeValue::TimeType>(arg1); | ||
| auto tv2 = static_cast<TimeValue::TimeType>(arg2); | ||
| bool neg = std::string_view(name) == "sub_time"; |
| double res = TimeValue::limit_with_bound(neg ? tv1 - tv2 : tv1 + tv2); | ||
| return res; | ||
| } else { | ||
| throw Exception(ErrorCode::INTERNAL_ERROR, "not support type for function {}", name); |
| auto tv2 = static_cast<TimeValue::TimeType>(arg2); | ||
| TimeInterval interval(TimeUnit::MICROSECOND, tv2, Impl::is_negative()); | ||
| bool out_range = dtv1.template date_add_interval<TimeUnit::MICROSECOND>(interval); | ||
| if (!out_range) { |
|
run buildall |
ClickBench: Total hot run time: 30.57 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
morrySnow
reviewed
Sep 28, 2025
|
|
||
| @Override | ||
| default FunctionSignature computeSignature(FunctionSignature signature) { | ||
| FunctionSignature ret = ComputeSignature.super.computeSignature(signature); |
| try { | ||
| String s = ((StringLikeLiteral) child(0)).getStringValue().trim(); | ||
| // check if the string is in the format of HH:MM:SS[.FFFFFF] | ||
| if (!s.contains("-")) { // avoid matching datetime format |
There was a problem hiding this comment.
i think we support 2008/08/08 too, why just process '-' here?
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
zclllyybb
requested changes
Sep 28, 2025
| String numberPart = parts[0]; | ||
|
|
||
| int length = numberPart.length(); | ||
| if (length < 7) { |
There was a problem hiding this comment.
why less? like 2001234, is also valid
|
|
||
| // Split time part | ||
| String[] timeFields = timePart.split(":"); | ||
| if (timeFields[0].length() == 2 || timeFields[0].length() == 3 || timePart.length() < 8) { |
There was a problem hiding this comment.
why timeFields[0].length() == 2? datetime also accepts it
dwdwqfwe
force-pushed
the
support_add_time
branch
from
111b7fa to
0e58a40
Compare
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support add_time/sub_time function like mysql:
https://dev.mysql.com/doc/refman/8.4/en/date-and-time-functions.html#function_addtime
Issue Number:
Related PR: apache/doris-website#2901
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)