Skip to content

[fix]: fix the show backends output column mismatch #61279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Baymine wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

[fix]: fix the show backends output column mismatch #61279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/common/proc/BackendsProcDir.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,6 @@ public static List<List<String>> getBackendInfos() {
// heartbeat failure counter
backendInfo.add(backend.getHeartbeatFailureCounter());

// node role, show the value only when backend is alive.
backendInfo.add(backend.isAlive() ? backend.getNodeRoleTag().value : "");

// cpu cores
backendInfo.add(String.valueOf(backend.getCputCores()));

Expand All @@ -167,6 +164,9 @@ public static List<List<String>> getBackendInfos() {
// runningFragments
backendInfo.add(String.valueOf(backend.getRunningTasks()));

// node role, show the value only when backend is alive.
backendInfo.add(backend.isAlive() ? backend.getNodeRoleTag().value : "");

comparableBackendInfos.add(backendInfo);
}

Expand Down
2 changes: 1 addition & 1 deletion fe/fe-core/src/test/java/org/apache/doris/utframe/DemoMultiBackendsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ public void testCreateDbAndTable() throws Exception {
+ "\"lastFragmentUpdateTime\":0}",
result.getRows().get(0).get(backendsTitleNames.size() - 7));
Assert.assertEquals("0", result.getRows().get(0).get(backendsTitleNames.size() - 6));
Assert.assertEquals(Tag.VALUE_MIX, result.getRows().get(0).get(backendsTitleNames.size() - 5));
Assert.assertEquals(Tag.VALUE_MIX, result.getRows().get(0).get(backendsTitleNames.size() - 1));
}

protected void alterTable(String sql, ConnectContext connectContext) throws Exception {
Expand Down
Loading