Skip to content

[refactor](Expr) Extract getString* methods to ExprToStringValueVisitor#61304

Open
morrySnow wants to merge 1 commit intoapache:masterfrom
morrySnow:expr_refactor
Open

[refactor](Expr) Extract getString* methods to ExprToStringValueVisitor#61304
morrySnow wants to merge 1 commit intoapache:masterfrom
morrySnow:expr_refactor

Conversation

@morrySnow
Copy link
Contributor

Move getStringValueForQuery, getStringValueInComplexTypeForQuery, and getStringValueForStreamLoad logic from 17 Expr subclasses into a centralized ExprToStringValueVisitor, following the same visitor pattern as ExprToSqlVisitor and ExprToThriftVisitor.

New classes:

  • ExprToStringValueVisitor: visitor with visit methods for DateLiteral, FloatLiteral, BoolLiteral, NullLiteral, DecimalLiteral, ArrayLiteral, MapLiteral, StructLiteral, CastExpr, StringLiteral, IPv4Literal, IPv6Literal, VarBinaryLiteral, PlaceHolderExpr, JsonLiteral, MaxLiteral
  • StringValueContext: carries FormatOptions and mode flags (forStreamLoad, inComplexType)

Expr base class methods now delegate to the visitor. Subclass overrides are removed. Also fixes pre-existing local variable naming in DateLiteral static block (DATE_KEY_FORMATTER -> dateKeyFmt) and makes convertToString private (no external callers).

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Move getStringValueForQuery, getStringValueInComplexTypeForQuery, and
getStringValueForStreamLoad logic from 17 Expr subclasses into a
centralized ExprToStringValueVisitor, following the same visitor pattern
as ExprToSqlVisitor and ExprToThriftVisitor.

New classes:
- ExprToStringValueVisitor: visitor with visit methods for DateLiteral,
  FloatLiteral, BoolLiteral, NullLiteral, DecimalLiteral, ArrayLiteral,
  MapLiteral, StructLiteral, CastExpr, StringLiteral, IPv4Literal,
  IPv6Literal, VarBinaryLiteral, PlaceHolderExpr, JsonLiteral, MaxLiteral
- StringValueContext: carries FormatOptions and mode flags (forStreamLoad,
  inComplexType)

Expr base class methods now delegate to the visitor. Subclass overrides
are removed. Also fixes pre-existing local variable naming in DateLiteral
static block (DATE_KEY_FORMATTER -> dateKeyFmt) and makes convertToString
private (no external callers).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants