[refactor](Expr) Extract getString* methods to ExprToStringValueVisitor#61304
Open
morrySnow wants to merge 1 commit intoapache:masterfrom
Open
[refactor](Expr) Extract getString* methods to ExprToStringValueVisitor#61304morrySnow wants to merge 1 commit intoapache:masterfrom
morrySnow wants to merge 1 commit intoapache:masterfrom
Conversation
Move getStringValueForQuery, getStringValueInComplexTypeForQuery, and getStringValueForStreamLoad logic from 17 Expr subclasses into a centralized ExprToStringValueVisitor, following the same visitor pattern as ExprToSqlVisitor and ExprToThriftVisitor. New classes: - ExprToStringValueVisitor: visitor with visit methods for DateLiteral, FloatLiteral, BoolLiteral, NullLiteral, DecimalLiteral, ArrayLiteral, MapLiteral, StructLiteral, CastExpr, StringLiteral, IPv4Literal, IPv6Literal, VarBinaryLiteral, PlaceHolderExpr, JsonLiteral, MaxLiteral - StringValueContext: carries FormatOptions and mode flags (forStreamLoad, inComplexType) Expr base class methods now delegate to the visitor. Subclass overrides are removed. Also fixes pre-existing local variable naming in DateLiteral static block (DATE_KEY_FORMATTER -> dateKeyFmt) and makes convertToString private (no external callers). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move getStringValueForQuery, getStringValueInComplexTypeForQuery, and getStringValueForStreamLoad logic from 17 Expr subclasses into a centralized ExprToStringValueVisitor, following the same visitor pattern as ExprToSqlVisitor and ExprToThriftVisitor.
New classes:
Expr base class methods now delegate to the visitor. Subclass overrides are removed. Also fixes pre-existing local variable naming in DateLiteral static block (DATE_KEY_FORMATTER -> dateKeyFmt) and makes convertToString private (no external callers).
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)