Skip to content

branch-4.0:[fix](sync) Treat empty cancel alter job list as all rollup jobs (#62712)#62964

Open
seawinde wants to merge 1 commit intoapache:branch-4.0from
seawinde:pr_62712_to_branch-4.0
Open

branch-4.0:[fix](sync) Treat empty cancel alter job list as all rollup jobs (#62712)#62964
seawinde wants to merge 1 commit intoapache:branch-4.0from
seawinde:pr_62712_to_branch-4.0

Conversation

@seawinde
Copy link
Copy Markdown
Member

pr: #62712
commitId: 98b9338

…che#62712)

Problem Summary:
Nereids always constructs a non-null alter job id list for `CANCEL ALTER
TABLE`, using an empty list when the SQL omits explicit job ids.
`SchemaChangeHandler` already treats an empty list as "cancel all
unfinished jobs on the table", but `MaterializedViewHandler` only
checked for `null`. As a result, `CANCEL ALTER TABLE ... ROLLUP FROM
db.tbl` could incorrectly search by explicit job ids, find nothing, and
throw `Table[...] is not under ROLLUP` even when the table still had
unfinished rollup jobs.

This change aligns `MaterializedViewHandler` with `SchemaChangeHandler`
by treating an empty job-id list the same as an omitted list, and adds
regression tests for both the handler path and the Nereids parser
behavior.
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@seawinde
Copy link
Copy Markdown
Member Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants