Skip to content

[fix](load) fix broker load silently loaded only the first file when parsing multiple files path#62969

Open
sollhui wants to merge 1 commit intoapache:masterfrom
sollhui:fix_load_multiple_files
Open

[fix](load) fix broker load silently loaded only the first file when parsing multiple files path#62969
sollhui wants to merge 1 commit intoapache:masterfrom
sollhui:fix_load_multiple_files

Conversation

@sollhui
Copy link
Copy Markdown
Contributor

@sollhui sollhui commented Apr 30, 2026

Proposed changes

Fix Nereids parsing for Broker Load statements that use multiple file paths in a single DATA INFILE clause, for example:

DATA INFILE("f1", "f2", "f3")

Previously, only the first file path was preserved. Later paths were parsed into a different ANTLR label and were not consumed by LogicalPlanBuilder, so Broker Load silently loaded only the first file.

This PR:

  • Uses one ANTLR list label for all DATA INFILE paths.

  • Updates LogicalPlanBuilder to build file paths from the collected list.

  • Adds FE unit coverage for parsed file paths.

  • Adds a regression case for S3 broker load with multiple paths in one DATA INFILE.

@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui
Copy link
Copy Markdown
Contributor Author

sollhui commented Apr 30, 2026

run buildall

Copy link
Copy Markdown
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Apr 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x dev/4.1.x reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants