Skip to content

[improvement](catalog) avoid loading every table for SHOW TABLES on external catalogs #66080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 7 commits into from
Aug 11, 2026
Merged

[improvement](catalog) avoid loading every table for SHOW TABLES on external catalogs #66080

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0e95d71
[improvement](catalog) avoid loading every table for SHOW TABLES on e…
Baymine Jul 26, 2026
6f15009
[fix](fe) SHOW TABLES on external catalog should still report case-in…
Baymine Jul 28, 2026
cad2f74
[improvement](catalog) add call-count tests for SHOW TABLES external …
Baymine Aug 4, 2026
e7e73e0
[test](catalog) Add unit tests for SHOW TABLES name listing on extern…
u70b3 Aug 4, 2026
5ebd771
Merge commit 'cad2f74d1ccdf9c7a6fa2ee4a6a6132102d7904c' into pr1-merge
u70b3 Aug 5, 2026
ab844b9
[test](catalog) Fold SHOW TABLES fast-path tests into ShowTableComman…
u70b3 Aug 5, 2026
52dc351
Merge pull request #1 from u70b3/test-show-tables-external-ut
Baymine Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowTableCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.apache.doris.common.ErrorReport;
import org.apache.doris.common.PatternMatcher;
import org.apache.doris.common.PatternMatcherWrapper;
import org.apache.doris.datasource.InternalCatalog;
import org.apache.doris.mysql.privilege.PrivPredicate;
import org.apache.doris.nereids.trees.plans.PlanType;
import org.apache.doris.nereids.trees.plans.commands.info.AliasInfo;
Expand Down Expand Up @@ -174,6 +175,23 @@ public ShowResultSet doRun(ConnectContext ctx, StmtExecutor executor) throws Exc
Preconditions.checkArgument(table.get().getType().equals(TableIf.TableType.STREAM));
rows.add(Lists.newArrayList(table.get().getName()));
}
} else if (!(dbIf.getCatalog() instanceof InternalCatalog)
Comment thread
Baymine marked this conversation as resolved.
&& !isVerbose && type.equals(PlanType.SHOW_TABLES)) {
// Non-verbose SHOW TABLES on an external catalog: list names directly
// instead of dbIf.getTables(), which loads every table via the meta
// cache (one remote metadata load per table). The per-table SHOW priv
// filter below must be kept (name-based, needs no table load).
for (String tableName : dbIf.getTableNamesOrEmptyWithLock()) {
if (matcher != null && !matcher.match(tableName)) {
continue;
}
if (!Env.getCurrentEnv().getAccessManager()
.checkTblPriv(ConnectContext.get(), catalog, dbIf.getFullName(), tableName,
PrivPredicate.SHOW)) {
continue;
}
rows.add(Lists.newArrayList(tableName));
}
} else {
for (TableIf tbl : dbIf.getTables()) {
if (type.equals(PlanType.SHOW_VIEWS) && (tbl.getEngine() == null
Expand Down
Loading