Skip to content

[fix](compaction): avoid decrementing uncounted cumulative compaction threads - #66752

Merged
gavinchou merged 4 commits into
apache:masterfrom
dzr171712:fix/CIR-26421
Aug 31, 2026
Merged

[fix](compaction): avoid decrementing uncounted cumulative compaction threads#66752
gavinchou merged 4 commits into
apache:masterfrom
dzr171712:fix/CIR-26421

Conversation

@dzr171712

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: None

Problem Summary:

In Cloud mode, cumulative compaction requests the tablet global compaction
lock before increasing _cumu_compaction_thread_pool_used_threads.

The cleanup Defer is created before the lock request. If the global lock
request fails, the task returns before the thread counter is incremented, but
the cleanup logic still decrements the counter. As a result,
_cumu_compaction_thread_pool_used_threads can become negative.

A negative thread counter can cause the cumulative compaction scheduling logic
to calculate the remaining thread capacity incorrectly and affect the
large-task delay decision.

This PR adds a guard to ensure that the thread counter is decremented only
when it has actually been incremented.

A regression unit test is added to simulate global compaction lock failure and
verify that the counter remains balanced.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • [✅] Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

    Test case:

    CloudCompactionTest.cumulative
    

@dzr171712
dzr171712 requested a review from gavinchou as a code owner August 14, 2026 02:48
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dzr171712

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 66.67% (2/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 60.38% (26507/43897)
Line Coverage 44.83% (270563/603466)
Region Coverage 40.57% (215633/531571)
Branch Coverage 41.98% (99272/236454)

@dzr171712

Copy link
Copy Markdown
Contributor Author

run p0

@dzr171712

Copy link
Copy Markdown
Contributor Author

run performance

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.15% (32583/42790)
Line Coverage 61.15% (366496/599333)
Region Coverage 57.92% (308827/533214)
Branch Coverage 59.23% (140045/236434)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.15% (32584/42790)
Line Coverage 61.15% (366497/599333)
Region Coverage 57.92% (308826/533214)
Branch Coverage 59.23% (140046/236434)

@dzr171712

Copy link
Copy Markdown
Contributor Author

run performance

1 similar comment
@dzr171712

Copy link
Copy Markdown
Contributor Author

run performance

@luwei16

luwei16 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 17159 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b4c4f61df1dce5e629ed53f7eebee8f226b6104, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17578	3103	3095	3095
q2	q3	10865	877	497	497
q4	4681	249	196	196
q5	7676	594	389	389
q6	140	117	92	92
q7	529	493	397	397
q8	9251	856	908	856
q9	3454	2410	2379	2379
q10	6507	863	726	726
q11	454	258	245	245
q12	686	405	330	330
q13	17868	1527	1156	1156
q14	160	148	137	137
q15	q16	471	395	369	369
q17	812	781	806	781
q18	3122	2263	2263	2263
q19	1269	867	782	782
q20	651	510	521	510
q21	5625	1731	1841	1731
q22	324	266	228	228
Total cold run time: 92123 ms
Total hot run time: 17159 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	3490	3390	3387	3387
q2	q3	2201	2324	2086	2086
q4	1198	1176	901	901
q5	2172	2119	2135	2119
q6	173	117	88	88
q7	1029	948	888	888
q8	1622	1437	1450	1437
q9	3195	3111	3127	3111
q10	1864	1776	1603	1603
q11	371	276	260	260
q12	453	434	345	345
q13	1498	1553	1158	1158
q14	174	163	163	163
q15	q16	395	387	353	353
q17	1058	1041	1053	1041
q18	4998	4426	4786	4426
q19	1389	895	842	842
q20	988	925	813	813
q21	3809	3132	3257	3132
q22	409	348	322	322
Total cold run time: 32486 ms
Total hot run time: 28475 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 80398 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b4c4f61df1dce5e629ed53f7eebee8f226b6104, data reload: false

query5	4290	417	337	337
query6	404	169	164	164
query7	4834	454	255	255
query8	302	129	120	120
query9	8677	2934	2924	2924
query10	379	260	216	216
query11	5407	1074	928	928
query12	120	72	71	71
query13	1212	460	328	328
query14	6114	2228	2126	2126
query14_1	2001	1998	1998	1998
query15	172	119	117	117
query16	979	397	308	308
query17	816	465	359	359
query18	2355	329	234	234
query19	179	141	115	115
query20	71	72	69	69
query21	222	117	102	102
query22	5320	5347	5250	5250
query23	6689	6143	6030	6030
query23_1	6129	6010	6088	6010
query24	7369	1107	752	752
query24_1	774	790	777	777
query25	437	275	232	232
query26	1254	260	154	154
query27	2736	431	286	286
query28	4674	1505	1483	1483
query29	931	417	343	343
query30	289	175	146	146
query31	854	420	358	358
query32	99	49	48	48
query33	470	200	180	180
query34	1114	801	457	457
query35	418	396	330	330
query36	611	557	523	523
query37	124	82	68	68
query38	1069	834	799	799
query39	493	480	487	480
query39_1	468	442	450	442
query40	254	117	108	108
query41	53	50	51	50
query42	84	78	73	73
query43	249	240	212	212
query44	
query45	107	100	102	100
query46	785	809	533	533
query47	751	754	713	713
query48	326	308	236	236
query49	551	237	181	181
query50	793	331	256	256
query51	8194	8263	8139	8139
query52	72	77	65	65
query53	201	218	166	166
query54	263	166	158	158
query55	80	57	54	54
query56	240	223	251	223
query57	711	688	643	643
query58	257	185	193	185
query59	1224	1254	1113	1113
query60	260	210	185	185
query61	119	130	136	130
query62	400	212	181	181
query63	186	155	158	155
query64	2860	665	643	643
query65	
query66	1943	316	249	249
query67	9884	9637	9723	9637
query68	
query69	396	226	197	197
query70	640	643	629	629
query71	316	267	235	235
query72	2552	2101	1713	1713
query73	739	583	342	342
query74	1561	1284	1152	1152
query75	1241	1152	1016	1016
query76	2540	731	555	555
query77	255	262	211	211
query78	3845	3697	3168	3168
query79	3220	779	590	590
query80	1653	418	374	374
query81	529	206	177	177
query82	739	134	107	107
query83	332	254	249	249
query84	
query85	883	433	369	369
query86	432	180	168	168
query87	1009	983	888	888
query88	2835	2139	2137	2137
query89	336	227	203	203
query90	1890	142	138	138
query91	153	134	123	123
query92	49	53	40	40
query93	1688	1106	728	728
query94	680	251	215	215
query95	609	354	396	354
query96	852	605	292	292
query97	1076	1065	1070	1065
query98	188	144	129	129
query99	459	350	315	315
Total cold run time: 174817 ms
Total hot run time: 80398 ms

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.74% (34082/45000)
Line Coverage 61.29% (387289/631936)
Region Coverage 57.93% (327786/565872)
Branch Coverage 58.89% (149785/254357)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.97% (34202/45023)
Line Coverage 61.42% (388703/632846)
Region Coverage 58.04% (329133/567078)
Branch Coverage 59.00% (150284/254734)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.99% (33762/45023)
Line Coverage 60.03% (379877/632846)
Region Coverage 56.31% (319326/567078)
Branch Coverage 57.12% (145513/254734)

1 similar comment
@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.99% (33762/45023)
Line Coverage 60.03% (379877/632846)
Region Coverage 56.31% (319326/567078)
Branch Coverage 57.12% (145513/254734)

@dzr171712

Copy link
Copy Markdown
Contributor Author

run cloud_p0

@dzr171712 dzr171712 changed the title [fix](cloud): avoid decrementing uncounted cumulative compaction threads [fix](compaction): avoid decrementing uncounted cumulative compaction threads Aug 18, 2026
@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.99% (33762/45023)
Line Coverage 60.03% (379877/632846)
Region Coverage 56.31% (319326/567078)
Branch Coverage 57.12% (145513/254734)

@dzr171712

Copy link
Copy Markdown
Contributor Author

run cloud_p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.99% (33762/45023)
Line Coverage 60.03% (379877/632846)
Region Coverage 56.31% (319326/567078)
Branch Coverage 57.12% (145513/254734)

@dzr171712

Copy link
Copy Markdown
Contributor Author

run cloud_p0

@dzr171712

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 17217 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit afb2e6595a3cb14d347b6efc84748b2a51e84fba, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17582	3079	3027	3027
q2	1899	239	152	152
q3	10454	860	509	509
q4	4672	249	209	209
q5	7666	571	387	387
q6	138	116	97	97
q7	532	491	386	386
q8	9247	967	921	921
q9	3485	2410	2421	2410
q10	6519	872	677	677
q11	443	256	237	237
q12	701	407	331	331
q13	17867	1518	1162	1162
q14	154	148	143	143
q15	q16	441	395	367	367
q17	795	747	752	747
q18	3164	2249	2285	2249
q19	1102	866	794	794
q20	680	577	456	456
q21	4847	1718	1830	1718
q22	325	269	238	238
Total cold run time: 92713 ms
Total hot run time: 17217 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3418	3352	3330	3330
q2	217	216	164	164
q3	2255	2292	2140	2140
q4	1212	1170	904	904
q5	2169	2115	2127	2115
q6	181	122	85	85
q7	1035	912	853	853
q8	1627	1434	1411	1411
q9	3147	3104	3110	3104
q10	1871	1804	1632	1632
q11	361	277	256	256
q12	455	439	342	342
q13	1497	1528	1169	1169
q14	163	168	171	168
q15	q16	396	392	357	357
q17	1063	1045	1042	1042
q18	4928	4440	4816	4440
q19	849	866	850	850
q20	963	969	824	824
q21	3564	3298	3336	3298
q22	415	343	338	338
Total cold run time: 31786 ms
Total hot run time: 28822 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 83950 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit afb2e6595a3cb14d347b6efc84748b2a51e84fba, data reload: false

query5	4267	424	352	352
query6	428	166	181	166
query7	4809	465	273	273
query8	301	124	140	124
query9	8691	2902	2921	2902
query10	414	263	233	233
query11	5365	1037	910	910
query12	118	70	74	70
query13	1193	425	326	326
query14	6042	2228	2128	2128
query14_1	1987	1972	1980	1972
query15	194	122	109	109
query16	925	390	363	363
query17	787	449	346	346
query18	2322	329	230	230
query19	178	145	118	118
query20	75	71	70	70
query21	215	116	100	100
query22	5319	5393	5309	5309
query23	6629	6247	6076	6076
query23_1	5988	5981	6106	5981
query24	7312	1078	761	761
query24_1	758	774	771	771
query25	445	310	276	276
query26	1273	261	174	174
query27	2719	451	296	296
query28	4605	1502	1500	1500
query29	941	445	365	365
query30	274	181	152	152
query31	878	428	355	355
query32	107	53	51	51
query33	464	212	195	195
query34	1016	809	499	499
query35	436	406	354	354
query36	590	543	516	516
query37	121	81	70	70
query38	1018	840	810	810
query39	490	484	473	473
query39_1	494	454	472	454
query40	221	127	109	109
query41	53	51	53	51
query42	87	82	83	82
query43	245	246	210	210
query44	1035	549	553	549
query45	113	104	103	103
query46	791	829	525	525
query47	770	749	715	715
query48	325	303	227	227
query49	539	241	187	187
query50	821	334	247	247
query51	8246	8129	8116	8116
query52	73	72	74	72
query53	214	229	162	162
query54	240	211	186	186
query55	75	58	59	58
query56	250	380	225	225
query57	724	676	657	657
query58	223	191	201	191
query59	1196	1235	1106	1106
query60	266	211	222	211
query61	119	132	130	130
query62	358	202	184	184
query63	191	160	157	157
query64	2753	719	686	686
query65	1631	1570	1618	1570
query66	1904	312	236	236
query67	9781	9749	9805	9749
query68	2778	1211	791	791
query69	348	227	203	203
query70	691	637	607	607
query71	293	252	241	241
query72	2306	1714	1562	1562
query73	671	628	351	351
query74	1574	1218	1141	1141
query75	1226	1150	1029	1029
query76	2285	730	541	541
query77	260	252	203	203
query78	3863	3625	3332	3332
query79	1211	781	602	602
query80	511	395	348	348
query81	426	202	172	172
query82	586	137	121	121
query83	356	267	238	238
query84	303	126	104	104
query85	827	439	397	397
query86	308	175	155	155
query87	998	969	881	881
query88	2821	2160	2145	2145
query89	318	238	207	207
query90	1917	145	151	145
query91	156	141	121	121
query92	51	50	51	50
query93	1187	1186	794	794
query94	436	279	225	225
query95	643	414	341	341
query96	766	589	288	288
query97	1034	1037	998	998
query98	146	152	130	130
query99	426	355	314	314
Total cold run time: 174516 ms
Total hot run time: 83950 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 14.5 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit afb2e6595a3cb14d347b6efc84748b2a51e84fba, data reload: false

query1	0.00	0.00	0.00
query2	0.08	0.04	0.04
query3	0.26	0.11	0.11
query4	1.60	0.11	0.11
query5	0.17	0.15	0.16
query6	1.25	0.68	0.71
query7	0.03	0.01	0.00
query8	0.05	0.03	0.03
query9	0.29	0.21	0.22
query10	0.36	0.35	0.35
query11	0.16	0.12	0.12
query12	0.15	0.13	0.12
query13	0.31	0.32	0.29
query14	0.45	0.44	0.45
query15	0.36	0.35	0.33
query16	0.22	0.23	0.22
query17	0.68	0.65	0.68
query18	0.18	0.17	0.16
query19	1.16	1.11	1.20
query20	0.01	0.00	0.01
query21	15.44	0.15	0.11
query22	5.09	0.04	0.05
query23	16.26	0.25	0.10
query24	3.02	0.32	0.25
query25	0.11	0.04	0.03
query26	0.77	0.17	0.11
query27	0.04	0.04	0.03
query28	3.63	0.58	0.27
query29	12.45	3.16	2.57
query30	0.25	0.11	0.12
query31	2.76	0.37	0.18
query32	3.53	0.30	0.24
query33	1.37	1.34	1.50
query34	15.39	2.18	1.75
query35	1.74	1.72	1.76
query36	0.47	0.29	0.29
query37	0.06	0.04	0.04
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.11	0.08	0.08
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 90.5 s
Total hot run time: 14.5 s

@dzr171712

Copy link
Copy Markdown
Contributor Author

run beut

@dzr171712

Copy link
Copy Markdown
Contributor Author

run beut

4 similar comments
@dzr171712

Copy link
Copy Markdown
Contributor Author

run beut

@dzr171712

Copy link
Copy Markdown
Contributor Author

run beut

@dzr171712

Copy link
Copy Markdown
Contributor Author

run beut

@dzr171712

Copy link
Copy Markdown
Contributor Author

run beut

@dzr171712

Copy link
Copy Markdown
Contributor Author

run but

@dzr171712

Copy link
Copy Markdown
Contributor Author

run beut

@dzr171712

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 16808 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 93ebc1fa5ba1689b1b92b93d5af77763866f2c75, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17672	3081	3063	3063
q2	2075	273	225	225
q3	10244	871	518	518
q4	4672	246	200	200
q5	7686	582	387	387
q6	140	116	94	94
q7	525	504	391	391
q8	9246	898	870	870
q9	3497	2395	2382	2382
q10	6511	854	724	724
q11	413	196	175	175
q12	625	264	196	196
q13	18120	1530	1191	1191
q14	158	150	135	135
q15	q16	425	398	363	363
q17	1438	907	749	749
q18	3019	2279	2207	2207
q19	1113	927	809	809
q20	379	283	203	203
q21	4859	1695	1841	1695
q22	330	263	231	231
Total cold run time: 93147 ms
Total hot run time: 16808 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3432	3360	3347	3347
q2	512	394	365	365
q3	2265	2283	2191	2191
q4	1188	1179	900	900
q5	2170	2132	2133	2132
q6	167	124	85	85
q7	1020	907	846	846
q8	1621	1413	1411	1411
q9	3159	3124	3100	3100
q10	1869	1806	1610	1610
q11	352	272	252	252
q12	450	426	346	346
q13	1488	1547	1164	1164
q14	175	173	153	153
q15	q16	396	402	359	359
q17	3676	3326	3289	3289
q18	4831	4537	4745	4537
q19	877	807	956	807
q20	1028	968	809	809
q21	3879	3122	3274	3122
q22	389	347	343	343
Total cold run time: 34944 ms
Total hot run time: 31168 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 81707 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 93ebc1fa5ba1689b1b92b93d5af77763866f2c75, data reload: false

query5	4261	401	320	320
query6	394	132	124	124
query7	4972	437	232	232
query8	302	126	113	113
query9	8678	2879	2884	2879
query10	411	220	184	184
query11	5383	1016	938	938
query12	122	72	72	72
query13	1192	445	322	322
query14	6070	2183	2081	2081
query14_1	1966	1943	1951	1943
query15	173	123	112	112
query16	942	383	354	354
query17	800	464	370	370
query18	2351	333	237	237
query19	168	142	109	109
query20	70	70	68	68
query21	197	100	88	88
query22	5309	5302	5311	5302
query23	6572	6172	5991	5991
query23_1	6141	5862	5997	5862
query24	7291	1099	782	782
query24_1	749	802	772	772
query25	459	285	244	244
query26	1228	229	121	121
query27	2793	409	255	255
query28	4696	1508	1488	1488
query29	930	428	338	338
query30	246	153	128	128
query31	818	394	316	316
query32	127	69	71	69
query33	454	214	171	171
query34	1010	834	494	494
query35	414	382	330	330
query36	561	539	518	518
query37	122	76	69	69
query38	999	840	781	781
query39	484	477	474	474
query39_1	465	462	487	462
query40	203	91	75	75
query41	53	50	51	50
query42	72	71	75	71
query43	242	241	211	211
query44	1014	540	559	540
query45	110	107	108	107
query46	770	849	507	507
query47	780	742	715	715
query48	295	295	222	222
query49	554	237	187	187
query50	693	261	201	201
query51	8309	8250	8308	8250
query52	66	67	58	58
query53	197	206	147	147
query54	234	177	159	159
query55	75	66	61	61
query56	203	173	154	154
query57	652	745	664	664
query58	213	156	167	156
query59	1242	1205	1100	1100
query60	248	210	174	174
query61	115	132	130	130
query62	366	204	185	185
query63	178	141	142	141
query64	2798	812	715	715
query65	1611	1618	1566	1566
query66	1884	272	262	262
query67	9739	9691	9542	9542
query68	3012	1198	715	715
query69	361	219	190	190
query70	657	591	634	591
query71	255	170	166	166
query72	2370	1769	1541	1541
query73	643	577	335	335
query74	2015	1229	1127	1127
query75	1171	1103	946	946
query76	2372	752	558	558
query77	258	261	212	212
query78	4050	3746	3197	3197
query79	2751	872	571	571
query80	1549	318	264	264
query81	538	152	135	135
query82	637	126	98	98
query83	289	207	184	184
query84	300	111	87	87
query85	853	342	301	301
query86	492	178	170	170
query87	1023	942	889	889
query88	3026	2084	2095	2084
query89	290	197	171	171
query90	2186	125	126	125
query91	131	119	97	97
query92	100	70	69	69
query93	2076	1115	684	684
query94	658	244	225	225
query95	519	309	231	231
query96	770	609	246	246
query97	1038	1035	1032	1032
query98	180	141	134	134
query99	425	350	299	299
Total cold run time: 179654 ms
Total hot run time: 81707 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 14.62 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 93ebc1fa5ba1689b1b92b93d5af77763866f2c75, data reload: false

query1	0.00	0.00	0.00
query2	0.08	0.04	0.04
query3	0.24	0.11	0.10
query4	1.60	0.10	0.09
query5	0.17	0.16	0.15
query6	1.27	0.70	0.67
query7	0.03	0.00	0.00
query8	0.05	0.03	0.03
query9	0.29	0.21	0.21
query10	0.36	0.37	0.37
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.30	0.30	0.30
query14	0.45	0.44	0.44
query15	0.36	0.34	0.34
query16	0.23	0.24	0.24
query17	0.73	0.67	0.67
query18	0.19	0.18	0.16
query19	1.09	1.15	1.08
query20	0.01	0.01	0.01
query21	15.43	0.17	0.12
query22	5.05	0.05	0.04
query23	16.26	0.25	0.11
query24	3.10	0.34	0.29
query25	0.10	0.05	0.04
query26	0.75	0.16	0.12
query27	0.04	0.03	0.03
query28	3.71	0.59	0.27
query29	12.41	3.21	2.55
query30	0.26	0.12	0.12
query31	2.75	0.38	0.17
query32	3.51	0.33	0.23
query33	1.58	1.50	1.44
query34	15.42	2.21	1.77
query35	1.74	1.73	1.70
query36	0.45	0.29	0.28
query37	0.06	0.04	0.03
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.11	0.07	0.08
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 90.7 s
Total hot run time: 14.62 s

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 62.54% (29198/46690)
Line Coverage 47.59% (305801/642541)
Region Coverage 43.22% (246769/570973)
Branch Coverage 44.79% (114911/256533)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 65.30% (29531/45221)
Line Coverage 50.12% (318336/635189)
Region Coverage 45.93% (261261/568805)
Branch Coverage 47.11% (120497/255804)

@dzr171712

Copy link
Copy Markdown
Contributor Author

run cloud_p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 65.30% (29531/45221)
Line Coverage 50.12% (318336/635189)
Region Coverage 45.93% (261261/568805)
Branch Coverage 47.11% (120497/255804)

@dzr171712

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 16896 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1a72a8dccba036c2dcfd6a039fc14a6b8550e6ee, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17720	3137	3156	3137
q2	2154	257	225	225
q3	10179	845	510	510
q4	4671	259	197	197
q5	7670	559	396	396
q6	135	114	96	96
q7	530	531	393	393
q8	9237	921	912	912
q9	3500	2414	2365	2365
q10	6494	847	694	694
q11	395	198	187	187
q12	614	260	194	194
q13	18141	1534	1169	1169
q14	160	150	140	140
q15	q16	430	395	376	376
q17	1273	883	734	734
q18	3043	2290	2291	2290
q19	1106	884	772	772
q20	366	280	199	199
q21	4812	1688	1860	1688
q22	323	272	222	222
Total cold run time: 92953 ms
Total hot run time: 16896 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3509	3431	3399	3399
q2	520	408	369	369
q3	2193	2309	2208	2208
q4	1204	1177	909	909
q5	2195	2160	2136	2136
q6	165	124	86	86
q7	1029	901	876	876
q8	1623	1433	1438	1433
q9	3182	3149	3129	3129
q10	1846	1801	1614	1614
q11	358	273	255	255
q12	451	432	346	346
q13	1490	1532	1163	1163
q14	178	168	165	165
q15	q16	393	398	360	360
q17	3616	3345	3232	3232
q18	4869	4499	4766	4499
q19	863	890	883	883
q20	984	988	857	857
q21	3928	3207	3267	3207
q22	405	354	328	328
Total cold run time: 35001 ms
Total hot run time: 31454 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 82616 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1a72a8dccba036c2dcfd6a039fc14a6b8550e6ee, data reload: false

query5	4265	410	333	333
query6	394	136	125	125
query7	4960	423	230	230
query8	305	129	117	117
query9	8685	2924	2931	2924
query10	381	212	183	183
query11	5386	1052	940	940
query12	130	79	75	75
query13	1207	440	306	306
query14	5994	2221	2101	2101
query14_1	1991	1975	1966	1966
query15	180	118	117	117
query16	981	370	385	370
query17	823	447	358	358
query18	2328	320	234	234
query19	184	131	100	100
query20	67	68	69	68
query21	208	96	83	83
query22	5379	5283	5386	5283
query23	6928	6206	6068	6068
query23_1	6220	6219	6151	6151
query24	7277	1110	751	751
query24_1	749	788	791	788
query25	422	286	234	234
query26	1265	237	128	128
query27	2765	418	248	248
query28	4681	1503	1489	1489
query29	943	439	342	342
query30	257	153	131	131
query31	814	406	326	326
query32	130	69	71	69
query33	488	215	169	169
query34	986	798	494	494
query35	415	385	346	346
query36	563	593	525	525
query37	122	82	74	74
query38	1014	844	796	796
query39	494	476	484	476
query39_1	476	480	496	480
query40	209	85	72	72
query41	56	52	50	50
query42	73	74	74	74
query43	237	240	209	209
query44	1034	548	555	548
query45	116	103	97	97
query46	780	879	555	555
query47	761	772	718	718
query48	302	310	228	228
query49	533	241	179	179
query50	709	260	200	200
query51	8268	8197	8368	8197
query52	74	68	65	65
query53	203	202	147	147
query54	237	237	195	195
query55	91	60	58	58
query56	202	171	179	171
query57	728	668	609	609
query58	224	180	186	180
query59	1225	1265	1115	1115
query60	246	190	185	185
query61	150	139	155	139
query62	371	202	179	179
query63	177	146	144	144
query64	2776	819	559	559
query65	1608	1607	1598	1598
query66	1823	248	192	192
query67	9958	9910	9696	9696
query68	3058	1175	758	758
query69	373	221	187	187
query70	669	625	625	625
query71	256	178	168	168
query72	2588	1796	1546	1546
query73	656	584	343	343
query74	2016	1228	1162	1162
query75	1180	1123	968	968
query76	2383	733	553	553
query77	245	261	212	212
query78	4049	3846	3320	3320
query79	2355	812	547	547
query80	1591	323	269	269
query81	516	152	133	133
query82	693	130	99	99
query83	286	219	192	192
query84	292	112	91	91
query85	797	372	299	299
query86	411	181	180	180
query87	1015	969	902	902
query88	2785	2098	2111	2098
query89	302	199	171	171
query90	2012	123	129	123
query91	134	129	101	101
query92	81	63	71	63
query93	1570	1130	749	749
query94	653	256	226	226
query95	538	318	221	221
query96	811	554	282	282
query97	1056	1055	1023	1023
query98	164	140	147	140
query99	440	357	310	310
Total cold run time: 179418 ms
Total hot run time: 82616 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 14.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1a72a8dccba036c2dcfd6a039fc14a6b8550e6ee, data reload: false

query1	0.00	0.01	0.00
query2	0.10	0.04	0.04
query3	0.27	0.11	0.11
query4	1.61	0.10	0.09
query5	0.18	0.17	0.15
query6	1.22	0.70	0.68
query7	0.03	0.00	0.01
query8	0.05	0.03	0.03
query9	0.29	0.23	0.22
query10	0.36	0.36	0.35
query11	0.17	0.11	0.12
query12	0.15	0.12	0.12
query13	0.31	0.31	0.31
query14	0.45	0.46	0.46
query15	0.36	0.35	0.35
query16	0.22	0.21	0.24
query17	0.68	0.66	0.71
query18	0.18	0.17	0.16
query19	1.22	1.16	1.18
query20	0.01	0.01	0.01
query21	15.48	0.15	0.11
query22	5.07	0.05	0.04
query23	16.07	0.27	0.11
query24	3.03	0.33	0.26
query25	0.13	0.04	0.04
query26	0.72	0.17	0.11
query27	0.05	0.03	0.03
query28	3.57	0.59	0.28
query29	12.42	3.18	2.60
query30	0.25	0.12	0.13
query31	2.75	0.36	0.17
query32	3.50	0.31	0.25
query33	1.59	1.51	1.48
query34	15.32	2.22	1.77
query35	1.78	1.75	1.73
query36	0.47	0.31	0.27
query37	0.06	0.03	0.04
query38	0.05	0.02	0.02
query39	0.04	0.02	0.02
query40	0.11	0.08	0.08
query41	0.08	0.02	0.03
query42	0.04	0.02	0.03
query43	0.03	0.03	0.02
Total cold run time: 90.47 s
Total hot run time: 14.8 s

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 62.72% (29344/46782)
Line Coverage 47.74% (307166/643436)
Region Coverage 43.33% (247919/572099)
Branch Coverage 44.90% (115412/257036)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.98% (34427/45308)
Line Coverage 60.96% (387719/636066)
Region Coverage 57.04% (325074/569912)
Branch Coverage 57.91% (148417/256299)

@gavinchou
gavinchou merged commit d113b43 into apache:master Aug 31, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants