branch-4.0:[fix](metrics) Guard query instance metric before metric repo init (#62762) - #67254
Open
seawinde wants to merge 1 commit into
Open
branch-4.0:[fix](metrics) Guard query instance metric before metric repo init (#62762)#67254seawinde wants to merge 1 commit into
seawinde wants to merge 1 commit into
Conversation
…pache#62762) ### What problem does this PR solve? Problem Summary: FE may throw a `NullPointerException` while registering query instances during startup or role switch. Root cause: In `QeProcessorImpl.registerInstances()` (`fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java:164`), query instance accounting always updates `MetricRepo.USER_COUNTER_QUERY_INSTANCE_BEGIN`, but `MetricRepo.init()` may not have completed yet, so the metric mapping is still unavailable. This PR keeps the existing query-instance accounting logic unchanged and only skips the metric increment until the metric repo is initialized.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr: #62762
commitId: d3d28c8