Skip to content

Fix bug for NestedCommonFormatColumnPartSerde #18850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgyrtkirk merged 4 commits into from
Dec 17, 2025
Merged

Fix bug for NestedCommonFormatColumnPartSerde #18850

kgyrtkirk merged 4 commits into from
Dec 17, 2025

Conversation

@cecemei
Copy link
Contributor

@cecemei cecemei commented Dec 16, 2025 •
edited
Loading

Fix bug for NestedCommonFormatColumnPartSerde

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added the GHA label Dec 16, 2025
@cecemei cecemei changed the title test-parser Fix bug for NestedCommonFormatColumnPartSerde Dec 17, 2025
@cecemei cecemei marked this pull request as ready for review December 17, 2025 01:56
kgyrtkirk
kgyrtkirk approved these changes Dec 17, 2025
View reviewed changes
Copy link
Member

@kgyrtkirk kgyrtkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me; fixes the issue I was seeing in #18847!

@kgyrtkirk kgyrtkirk merged commit aac2d0b into apache:master Dec 17, 2025
55 checks passed
abhishekrb19
abhishekrb19 reviewed Dec 17, 2025
View reviewed changes
processing/src/main/java/org/apache/druid/segment/serde/NestedCommonFormatColumnPartSerde.java
Comment on lines +485 to +486
@JsonProperty("longFieldBitmapIndexType")@Nullable BitmapIndexType longFieldBitmapIndex,
@JsonProperty("doubleFieldBitmapIndexType")@Nullable BitmapIndexType doubleFieldBitmapIndex
Copy link
Contributor

@abhishekrb19 abhishekrb19 Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also rename these arguments to align with the json property names and stuff that's defined in the underlying spec NestedCommonFormatColumnFormatSpec:

  • longFieldBitmapIndex -> longFieldBitmapIndexType
  • doubleFieldBitmapIndex -> doubleFieldBitmapIndexType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhishekrb19 abhishekrb19 abhishekrb19 left review comments

@kgyrtkirk kgyrtkirk kgyrtkirk approved these changes

Assignees

No one assigned

Labels

Area - Segment Format and Ser/De GHA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cecemei @kgyrtkirk @abhishekrb19