-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fixed ClassCastException during Multi-Stage Queries on real-time segments #18859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nozjkoitop
wants to merge
17
commits into
apache:master
Choose a base branch
from
deep-bi:feature-fix-msq-with-hllsketch-in-realtime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed ClassCastException during Multi-Stage Queries on real-time segments #18859
nozjkoitop
wants to merge
17
commits into
apache:master
from
deep-bi:feature-fix-msq-with-hllsketch-in-realtime
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat include columns of HLLSketch type resulted in a ClassCastException.
…ith-hllsketch-in-realtime
…ith-hllsketch-in-realtime
…ith-hllsketch-in-realtime # Conflicts: # extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestBase.java
…ith-hllsketch-in-realtime
Contributor
Author
|
Hey @LakshSingla @adarshsanjeev can you help in reviewing this? As you already participated in my previous attempt to fix that :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area - Batch Ingestion
Area - MSQ
For multi stage queries - https://github.com/apache/druid/issues/12262
Area - Segment Format and Ser/De
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a refreshed version of the previously closed PR: #16607
It fixes a failure when MSQ queries run with "includeSegmentSource": "REALTIME" while a supervisor is ingesting and the query reads realtime data.
Before Druid 31, the UI surfaced a ClassCastException (stack trace below). In newer versions it appears as an NPE, but the underlying cause is the same
On the realtime segment path, the selector’s getObject() (used by ComplexFieldWriter) can return a byte[] that is already the serialized form of an HLL sketch.
However, later serde assumes the complex metric value is the object form (HllSketchHolder) and passes it into HllSketchHolderObjectStrategy.toBytes(), which expects an HllSketchHolder. When it receives a byte[] instead, it results in the ClassCastException shown above.
How to reproduce
Run an MSQ select for a realtime data with "includeSegmentSource": "REALTIME" in the context
This PR has: