Skip to content

Increase code coverage for DirectDruidClientTest #18861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
abhishekrb19 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase code coverage for DirectDruidClientTest #18861

abhishekrb19 wants to merge 1 commit into from
+233 −315

Conversation

@abhishekrb19
Copy link
Contributor

@abhishekrb19 abhishekrb19 commented Dec 19, 2025

Test-only change:

  • Increases test coverage for the DirectDruidClient class from 57%, 35%, 16% to 73%, 69%, 43% for method / line / branch coverage respectively. We can add more tests as we evolve the code and/or do bug fixes.
  • Replaces mocks with more concrete classes and test helpers, allowing the internals of the class, including HttpResponseHandler to be exercised.
  • Also added a test for feat: log total bytes gathered when max scatter-gather bytes limit is reached #18841 for which coverage had to be skipped

This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.

@abhishekrb19
Better DirectDruidClientTest for code coverage
bd4259c 
Replaces mocks with more concrete test helpers that will invoke and exercise the internals
of DirectDruidClient response handler, etc. Also, add a new unit test for
ResourceExceededException that wasn't previously exercised.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@abhishekrb19