feat: MSQ: Log full stack trace when "debug" is set.#19361
Merged
gianm merged 1 commit intoapache:masterfrom Apr 21, 2026
Merged
feat: MSQ: Log full stack trace when "debug" is set.#19361gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
Typically controllers and workers only log the full stack trace for unknown faults and for DruidExceptions that have a non-USER persona. The rationale is to avoid log spam. However, sometimes it is useful to see them. This patch changes things so the full stack traces are logged when the "debug" flag is set in the context. Test contexts are also updated such that the full stack trace is always logged in tests. Finally, this patch also calls "wasDeserialized()" on the DruidException builder when re-creating DruidExceptions on the controller. This avoids having a stack trace assigned that isn't useful.
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
capistrant
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically controllers and workers only log the full stack trace for unknown faults and for DruidExceptions that have a non-USER persona. The rationale is to avoid log spam. However, sometimes it is useful to see them. This patch changes things so the full stack traces are logged when the "debug" flag is set in the context.
Test contexts are also updated such that the full stack trace is always logged in tests.
Finally, this patch also calls "wasDeserialized()" on the DruidException builder when re-creating DruidExceptions on the controller. This avoids having a stack trace assigned that isn't useful.