refactor: clean up min/max task count limits in streaming task autoscaler#19369
Draft
jtuglu1 wants to merge 1 commit intoapache:masterfrom
Draft
refactor: clean up min/max task count limits in streaming task autoscaler#19369jtuglu1 wants to merge 1 commit intoapache:masterfrom
jtuglu1 wants to merge 1 commit intoapache:masterfrom
Conversation
| return getIOConfig(taskCount, scaleOut, 2); | ||
| } | ||
|
|
||
| private SeekableStreamSupervisorIOConfig getIOConfig(int taskCount, boolean scaleOut, int maxTaskCount) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes auto-scaling min/max handling done in a single place (since it is common logic shared by all auto-scalers) in the supervisor dynamic task call action. This also cleans up the task auto scaler contract of returning
-1only when the scaler failed to produce a desired task count (lack of metrics, etc.). Otherwise, it is expected to return a task count that the supervisor will then audit/clamp.Release note
Clean up min/max task count limits in streaming task autoscaler
This PR has: