Skip to content

feat: Include caller thread name in LimitedPoolIndexMerger threads. #19376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
Apr 25, 2026
+28 −60
Merged

feat: Include caller thread name in LimitedPoolIndexMerger threads. #19376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions processing/src/main/java/org/apache/druid/common/guava/ThreadRenamingRunnable.java
View file
Open in desktop

This file was deleted.

36 changes: 28 additions & 8 deletions ...va/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppenderatorsManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,16 +555,26 @@ public File persist(
@Nullable SegmentWriteOutMediumFactory segmentWriteOutMediumFactory
)
{
ListenableFuture<File> mergeFuture = mergeExecutor.submit(
() ->
baseMerger.persist(
// Include calling thread's name in the mergeExecutor thread name. This includes at least the task ID.
final String callerThreadName = Thread.currentThread().getName();
final ListenableFuture<File> mergeFuture = mergeExecutor.submit(
() -> {
final String runnableThreadName = Thread.currentThread().getName();
try {
Thread.currentThread().setName(runnableThreadName + "[" + callerThreadName + "]");
return baseMerger.persist(
index,
dataInterval,
outDir,
indexSpec,
progress,
segmentWriteOutMediumFactory
)
);
}
finally {
Thread.currentThread().setName(runnableThreadName);
}
}
);

try {
Expand Down Expand Up @@ -604,9 +614,14 @@ public File mergeQueryableIndex(
int maxColumnsToMerge
)
{
ListenableFuture<File> mergeFuture = mergeExecutor.submit(
() ->
baseMerger.mergeQueryableIndex(
// Include calling thread's name in the mergeExecutor thread name. This includes at least the task ID.
final String callerThreadName = Thread.currentThread().getName();
final ListenableFuture<File> mergeFuture = mergeExecutor.submit(
() -> {
final String runnableThreadName = Thread.currentThread().getName();
try {
Thread.currentThread().setName(runnableThreadName + "[" + callerThreadName + "]");
return baseMerger.mergeQueryableIndex(
indexes,
rollup,
metricAggs,
Expand All @@ -617,7 +632,12 @@ public File mergeQueryableIndex(
new BaseProgressIndicator(),
segmentWriteOutMediumFactory,
maxColumnsToMerge
)
);
}
finally {
Thread.currentThread().setName(runnableThreadName);
}
}
);

try {
Expand Down
Loading