fix: Fix bug in reindexCascade timeline generation where too many search intervals are skipped#19389
Merged
gianm merged 1 commit intoapache:masterfrom Apr 29, 2026
Conversation
Member
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
This is an automated review by Codex GPT-5
gianm
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The original implementation is not incorrect in its application of skip offsets, but it is overly conservative. The way the original code works is that it:
a. If the interval end falls after the calculated skip offset threshold (if skipOffsetFromNow or skipOffsetFromLatest is set), do not create jobs for the search interval
2a. is overly conservative. It is completely valid to take such an interval and truncate its end to
granularity.bucketStart(skipOffsetThreshold)where granularity is the segment granularity of the search interval, and skipOffsetThreshold is the calculated threshold that we must skip creating compaction jobs for any data after. If the interval created by the original start and new end is valid, we can create compaction jobs for it.Release note
Be more precise in applying skipOffsetFromNow and skipOffsetFromLatest when using reindexCascade compaction supervisor. Previously more search intervals than necessary could be skipped when generating compaction jobs if you were using one of the two skip offset styles.
Key changed/added classes in this PR
CascadingReindexingTemplateThis PR has: