feat: Extension point for MSQ InputSpecs.#19479
Open
gianm wants to merge 4 commits into
Open
Conversation
This patch adds extension points for InputSpecSlicer and InputSliceReader, and uses them to implement TableInputSpec. This eliminates and generalizes the "newTableInputSpecSlicer" method on the ControllerContext, which was previously needed because the slicing logic differs for tasks and Dart.
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
Reviewed 27 of 27 changed files.
This is an automated review by Codex GPT-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds extension points for
InputSpecSlicerandInputSliceReader, and uses them to implementTableInputSpec. This eliminates and generalizes thenewTableInputSpecSlicermethod on theControllerContext, which was previously needed because the slicing logic differs for tasks and Dart.