Implment Counter in local cache#1345
Merged
robocanic merged 1 commit intoNov 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a counter management system that tracks resource statistics (applications, services, instances) and their distributions (protocols, releases, discoveries) through event-driven updates. The counter manager listens to resource events via the event bus and maintains real-time counts that can be queried through the cluster overview API endpoint.
Key changes:
- New counter manager component that subscribes to resource change events and maintains aggregated statistics
- Updated event bus to prefer NewObj() over OldObj() when determining resource kind for event routing
- Integration of counter manager into the bootstrap sequence and console context
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/core/events/component.go | Modified event routing to check NewObj() first before falling back to OldObj() |
| pkg/core/bootstrap/bootstrap.go | Added counter manager initialization step in the bootstrap sequence |
| pkg/console/handler/overview.go | Updated ClusterOverview handler to use counter manager data |
| pkg/console/counter/manager.go | New counter manager implementation with event handlers and statistics tracking |
| pkg/console/counter/counter.go | New counter primitives (Counter and DistributionCounter) with thread-safe operations |
| pkg/console/counter/component.go | New runtime component wrapper for counter manager |
| pkg/console/context/context.go | Added CounterManager accessor to console context |
Comments suppressed due to low confidence (1)
pkg/core/bootstrap/bootstrap.go:123
- Corrected spelling of 'Diagnotics' to 'Diagnostics' in the function name.
func initializeDiagnoticsServer(builder *runtime.Builder) error {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
65
to
67
| // 7. initialize diagnotics | ||
| if err := initializeDiagnoticsServer(builder); err != nil { | ||
| logger.Errorf("got error when init diagnotics server %s", err) |
There was a problem hiding this comment.
Corrected spelling of 'diagnotics' to 'diagnostics'.
Suggested change
| // 7. initialize diagnotics | |
| if err := initializeDiagnoticsServer(builder); err != nil { | |
| logger.Errorf("got error when init diagnotics server %s", err) | |
| // 7. initialize diagnostics | |
| if err := initializeDiagnosticsServer(builder); err != nil { | |
| logger.Errorf("got error when init diagnostics server %s", err) |
Comment on lines
65
to
67
| // 7. initialize diagnotics | ||
| if err := initializeDiagnoticsServer(builder); err != nil { | ||
| logger.Errorf("got error when init diagnotics server %s", err) |
There was a problem hiding this comment.
Corrected spelling of 'diagnotics' to 'diagnostics'.
Suggested change
| // 7. initialize diagnotics | |
| if err := initializeDiagnoticsServer(builder); err != nil { | |
| logger.Errorf("got error when init diagnotics server %s", err) | |
| // 7. initialize diagnostics | |
| if err := initializeDiagnosticsServer(builder); err != nil { | |
| logger.Errorf("got error when init diagnostics server %s", err) |
Comment on lines
+103
to
+105
| for k := range c.data { | ||
| delete(c.data, k) | ||
| } |
There was a problem hiding this comment.
The Reset() method iteratively deletes map entries which can be inefficient. Consider replacing the map with a new empty map: c.data = make(map[string]int64).
Suggested change
| for k := range c.data { | |
| delete(c.data, k) | |
| } | |
| c.data = make(map[string]int64) |
Comment on lines
+60
to
+63
| return newCounterManager() | ||
| } | ||
|
|
||
| func newCounterManager() *counterManager { |
There was a problem hiding this comment.
[nitpick] The exported function NewCounterManager() simply wraps the unexported newCounterManager() with no additional logic. This adds unnecessary indirection. Consider removing newCounterManager() and implementing the logic directly in NewCounterManager().
Suggested change
| return newCounterManager() | |
| } | |
| func newCounterManager() *counterManager { |
robocanic
reviewed
Nov 2, 2025
Contributor
robocanic
left a comment
robocanic
left a comment
There was a problem hiding this comment.
Great work! I find some issues, you can discuss it with me for a better PR
| Increment(counterType CounterType) error | ||
| Decrement(counterType CounterType) error | ||
| IncrementDistribution(counterType CounterType, key string) error | ||
| DecrementDistribution(counterType CounterType, key string) error |
Contributor
There was a problem hiding this comment.
suggestion: Increment,Decrement,IncrementDistribution,DecrementDistribution这几个接口以及接口实现放在CounterManager这个Manager中不太合适。从架构上来说，CounterManager是Counter的管理者，对外提供的应该是类似AddCounter，DeleteCounter()这样的方法
| return nil | ||
| } | ||
|
|
||
| func (cm *counterManager) Overview() *model.OverviewResp { |
Contributor
There was a problem hiding this comment.
suggestion: Overview这个方法里的逻辑应该要放到web层来做，CounterManager只专注于count。暴露给外层的应该只是一个类似GetCount(ResourceKind)这样的方法
| type CounterType string | ||
|
|
||
| const ( | ||
| ApplicationCounter CounterType = "application" |
Contributor
There was a problem hiding this comment.
suggestion：如果要增加某种类型的Counter，需要新增counterType，和对应的事件回调函数。看能不能在易用性上完善一下。可以参考的思路如下：
拆解一下Counter的类型，目前定义的counter有两种，一种是记录某种resource的累计数量(ResourceKind->countValue)，另一种是记录根据resource的某一个字段的累计数量(ResourceKind->{key,value})，这两种都可以关联到ResourceKind上。对于第一种counter，可以以resourceKind为map key，simple counter为map value，不同的resource的事件处理逻辑完全一致，因此可以统一起来。对于第二种counter，可以以resourceKind为map key，distribution counter为map value，每种key的处理逻辑不一样，所以可以把这个处理逻辑抽象成一个func类型，这个func关注一个事件，返回一个数值，然后把这个数值更新到distribution counter的key上。至此，两种counter类型都可以关联到resourcekind上，对其他组件来说，如果想新增一种类型的counter，只需要少量甚至不需要额外代码就能扩展的。
WyRainBow
force-pushed
the
feature/homepage-counter-manager
branch
4 times, most recently
from
7ede54a to
2106377
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+103
to
+105
| for k := range c.data { | ||
| delete(c.data, k) | ||
| } |
There was a problem hiding this comment.
The DistributionCounter.Reset() method iterates through the map and deletes entries one by one. For better performance and idiomatic Go code, consider replacing the map with a new one: c.data = make(map[string]int64) instead of iterating and deleting.
Suggested change
| for k := range c.data { | |
| delete(c.data, k) | |
| } | |
| c.data = make(map[string]int64) |
Comment on lines
+60
to
+62
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ProtocolCounter, instanceProtocolKey) | ||
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ReleaseCounter, instanceReleaseKey) | ||
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, DiscoveryCounter, instanceMeshKey) |
There was a problem hiding this comment.
The functions instanceProtocolKey, instanceReleaseKey, and instanceMeshKey are referenced here but are defined in manager.go and are not exported. This creates an unnecessary dependency and couples the component to internal implementation details of the manager package. Consider either exporting these functions or passing them as configuration when creating the component.
Suggested change
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ProtocolCounter, instanceProtocolKey) | |
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ReleaseCounter, instanceReleaseKey) | |
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, DiscoveryCounter, instanceMeshKey) | |
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ProtocolCounter, InstanceProtocolKey) | |
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ReleaseCounter, InstanceReleaseKey) | |
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, DiscoveryCounter, InstanceMeshKey) |
| if err := initializeCounterManager(builder); err != nil { | ||
| return nil, err | ||
| } | ||
| // 7. initialize diagnotics |
There was a problem hiding this comment.
Typo in the comment: "diagnotics" should be "diagnostics".
Comment on lines
+56
to
+63
| mgr.RegisterSimpleCounter(meshresource.ApplicationKind) | ||
| mgr.RegisterSimpleCounter(meshresource.ServiceKind) | ||
| mgr.RegisterSimpleCounter(meshresource.InstanceKind) | ||
|
|
||
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ProtocolCounter, instanceProtocolKey) | ||
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ReleaseCounter, instanceReleaseKey) | ||
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, DiscoveryCounter, instanceMeshKey) | ||
|
|
There was a problem hiding this comment.
The counter initialization logic is duplicated. NewCounterManager() already registers these counters (lines 73-79 in manager.go), but they are being registered again in the Init method here. This duplication is unnecessary and could lead to maintenance issues.
Suggested change
| mgr.RegisterSimpleCounter(meshresource.ApplicationKind) | |
| mgr.RegisterSimpleCounter(meshresource.ServiceKind) | |
| mgr.RegisterSimpleCounter(meshresource.InstanceKind) | |
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ProtocolCounter, instanceProtocolKey) | |
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, ReleaseCounter, instanceReleaseKey) | |
| mgr.RegisterDistributionCounter(meshresource.InstanceKind, DiscoveryCounter, instanceMeshKey) |
robocanic
reviewed
Nov 9, 2025
Contributor
robocanic
left a comment
robocanic
left a comment
There was a problem hiding this comment.
Excellent work! Please review the comments Copilot and I left.
| raw := counter.GetAll() | ||
| result := make(map[string]int, len(raw)) | ||
| for k, v := range raw { | ||
| result[k] = safeInt64ToInt(v) |
Contributor
There was a problem hiding this comment.
suggestion: 这里可以直接在接口层面返回int64，因为指标数量可能确实会超过int32
WyRainBow
force-pushed
the
feature/homepage-counter-manager
branch
from
2106377 to
d439621
Compare
WyRainBow
force-pushed
the
feature/homepage-counter-manager
branch
from
d439621 to
9ae6294
Compare
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if event == nil { | ||
| return false | ||
| } | ||
| return event.OldObj() == nil |
There was a problem hiding this comment.
The function name isNewResourceEvent is ambiguous. It checks if OldObj is nil but doesn't verify NewObj exists. This could return true for events where both objects are nil. Consider renaming to hasNoOldObject or add validation that NewObj is not nil to truly identify new resource events.
Suggested change
| return event.OldObj() == nil | |
| return event.OldObj() == nil && event.NewObj() != nil |
Comment on lines
+241
to
+246
| if oldObj != nil { | ||
| cfg.counter.Decrement(oldKey) | ||
| } | ||
| if newObj != nil { | ||
| cfg.counter.Increment(newKey) | ||
| } |
There was a problem hiding this comment.
The update logic incorrectly checks if oldObj/newObj are nil after already extracting and normalizing keys from them. At this point, if the objects were nil, the keys would already be 'unknown'. The nil checks should occur before key extraction at line 236-237, or these checks should be removed as they are now redundant and could cause incorrect counter updates.
Suggested change
| if oldObj != nil { | |
| cfg.counter.Decrement(oldKey) | |
| } | |
| if newObj != nil { | |
| cfg.counter.Increment(newKey) | |
| } | |
| cfg.counter.Decrement(oldKey) | |
| cfg.counter.Increment(newKey) |
robocanic
added a commit
that referenced
this pull request
May 10, 2026
* feat: informer general framework and engine/discovery interface definition (#1314) * feat: informer general framework and engine/discovery interface definition * fix: ci problem; directory and dependency tidy (#1320) * fix: ci probelm; diretory and dependency tidy * fix: lack license header * rm: remove redundant file * ci(makefile): add makefile for ci (#1322) * ci(makefile): add makefile for ci * style(ci): rename dubbo-admin ci * delete unused ci (#1326) * fix: refractor web handler and service to fix compile error; (#1325) * fix: refractor web handler and service to fix compile error; * feat: support memory type of store (#1332) * feat: support memory type of store * fix: muilti indexes should use intersecection * simplify code Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refractor: GetByKeys return a list instead of map --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: support kubernetes as a backend engine (#1340) * feat: implement runtime engine using kubernetes * feat: Defined a unified error (#1353) * feat: unified error code; separate application handler and service into parts * fix: license header lack * fix: copilot review err fix * fix: simplify the if-else condition * chore: rename Error() to String() * chore: add extra String() in Error * feat: 新增listMeshes接口 * fix: copilot review * Implment Counter in local cache (#1345) * fix: update response interceptor to handle success and error messages more accurately (#1355) * feat(UI): Support multiple registries (#1356) * feat(#1352): Support multiple registries: add registry select box and refresh main area on change * doc(build): build ui * fix(#1352): Set first available mesh after login when no mesh is set * doc(build): build ui * fix(conflict) * doc(build): build ui * feat: implement mysql and postgresql store for resources (#1360) * feat: implement mysql and postgresql store for resources * fix some issues * ut: add some test cases * fix: dynamic table name * feat: implements discovery backend by nacos (#1367) * feat: support nacos2 to do discovery * refractor: abstract nacos and nacos service * fix: unit test and license header * fix: copilot review problem * chore: remove redundant code * fix counter bug (#1369) * fix: add indexer before init cause npe (#1372) * fix: add indexer before init cause npe * fix: unit test * Fix: Redirect to login page when receiving 401 unauthorized response from API (#1373) * feat: enhance error handling for unauthorized access and improve toast messages * feat: enhance error handling for unauthorized access and improve toast messages * fix: correct syntax error in response interceptor for redirect handling * Update ui-vue3/src/base/http/request.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: add YAML and XML editor components, update index references, and enhance error logging - Introduced new JavaScript files for YAML and XML syntax highlighting and editing capabilities. - Added a new component for updating YAML configurations with a structured editor interface. - Updated the index.html to reference the new JavaScript bundle for improved functionality. - Enhanced the HTTP request module to log errors during redirection on 401 responses for better debugging. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: implement discovery backend by zk (#1371) * feat: implements discovery backend by zk * feat: support components to start in dependency order (#1370) * feat: support components to start in dependency order * imporve * fix * fix error import * release changelog (#1376) * changelog * chore: rename refactor to enhancements * refactor: 🎨 Optimize UI styles and search functionality (#1379) * feat: enhance error handling for unauthorized access and improve toast messages * feat: enhance error handling for unauthorized access and improve toast messages * fix: correct syntax error in response interceptor for redirect handling * Update ui-vue3/src/base/http/request.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat: add YAML and XML editor components, update index references, and enhance error logging - Introduced new JavaScript files for YAML and XML syntax highlighting and editing capabilities. - Added a new component for updating YAML configurations with a structured editor interface. - Updated the index.html to reference the new JavaScript bundle for improved functionality. - Enhanced the HTTP request module to log errors during redirection on 401 responses for better debugging. * docs: Only supports exact matching; remove the "prefix search" function from the placeholder (background word) * docs: All sorting indicators for lists are initially hidden, including but not limited to the list pages for applications, instances, services, and traffic management * refactor: 🎨 Optimize the styles of some tables and adapt to backend changes * docs: api baseurl --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * feat(ui): Enhance service metrics display and optimize table UI styles (#1383) * build: Optimize the styles of some tables, adapt to backend changes, format the code, and package it * chore: remove PR_DESCRIPTION.md file as it is no longer needed * fix: update routing rule handling updated routing rule handling to use constants for HTTP status codes in various components. * build: build & format * feat: enhance error handling and data loading in various components (#1385) * build: Optimize the styles of some tables, adapt to backend changes, format the code, and package it * chore: remove PR_DESCRIPTION.md file as it is no longer needed * fix: update routing rule handling updated routing rule handling to use constants for HTTP status codes in various components. * build: build & format * feat: enhance error handling and data loading in various components - Added a silent error handling mechanism for specific URLs in the HTTP request module to suppress error messages. - Refactored data loading logic in sceneConfig.vue to load configuration data based on the selected tab, improving user experience. - Updated YAMLView.vue and other components to remove unused button code and optimize imports, enhancing code clarity and maintainability. - Improved error handling in routingRule and dynamicConfig components to ensure better user feedback and debugging. * feat: add new components and enhance YAML and XML editing capabilities - Introduced new JavaScript files for YAML and XML syntax highlighting and editing. - Added components for updating YAML configurations with structured editor interfaces. - Updated index.html to reference new JavaScript bundles for improved functionality. - Enhanced error handling and logging in various components for better debugging. - Removed unused code and optimized imports in YAMLView and related components. * feat: fix console bugs and makes console functions effective (#1378) * fix: console interfaces;feat: implements governor using zk and nacos * fix: instance subscriber * fix: unit-test * fix: rules search * resolve conflicts * fix: backend bugs * fix: rule handler and service refactor * fix: config error andd field mapping * fix: rename msg to message * fix: wrap prometheus error * fix ci * feat: add deploy manifests and fix metric and trace dashboard bugs (#1387) * feat: add monitoring/dubbo-samples-shop/dubbo-system resources * fix: metric, trace dashboard bug * Fix: Address the admin issues before the release (#1391) * build: Optimize the styles of some tables, adapt to backend changes, format the code, and package it * chore: remove PR_DESCRIPTION.md file as it is no longer needed * fix: update routing rule handling updated routing rule handling to use constants for HTTP status codes in various components. * build: build & format * feat: enhance error handling and data loading in various components - Added a silent error handling mechanism for specific URLs in the HTTP request module to suppress error messages. - Refactored data loading logic in sceneConfig.vue to load configuration data based on the selected tab, improving user experience. - Updated YAMLView.vue and other components to remove unused button code and optimize imports, enhancing code clarity and maintainability. - Improved error handling in routingRule and dynamicConfig components to ensure better user feedback and debugging. * feat: add new components and enhance YAML and XML editing capabilities - Introduced new JavaScript files for YAML and XML syntax highlighting and editing. - Added components for updating YAML configurations with structured editor interfaces. - Updated index.html to reference new JavaScript bundles for improved functionality. - Enhanced error handling and logging in various components for better debugging. - Removed unused code and optimized imports in YAMLView and related components. * feat: enhance UI components and improve error handling - Added global styles for clickable links in tables to improve user interaction. - Updated routing logic to utilize a dynamic header parameter key for better flexibility. - Enhanced error handling in HTTP requests to suppress messages for specific URLs. - Improved internationalization by adding new translation keys for 'Ready Time' in both English and Chinese. - Refactored various components to optimize code structure and maintainability, including updates to YAML and form views. - Adjusted table and form layouts for better responsiveness and user experience. * refactor: streamline component code and enhance condition handling - Simplified iframe rendering in GrafanaPage.vue for improved readability. - Added checks in ConfigModel.ts to skip undefined keys in matches and parameters. - Optimized YAMLView.vue by condensing MonacoEditor properties for better clarity. - Cleared default request and address matching arrays in formView.vue for cleaner initialization. - Enhanced condition parsing and merging logic in updateByFormView.vue to improve maintainability and readability. * build: build admin * fix: add Apache License headers to YAML files in release/kubernetes (#1393) * feat: enhance UI components, improve error handling, and add routing rule management (#1394) * build: Optimize the styles of some tables, adapt to backend changes, format the code, and package it * chore: remove PR_DESCRIPTION.md file as it is no longer needed * fix: update routing rule handling updated routing rule handling to use constants for HTTP status codes in various components. * build: build & format * feat: enhance error handling and data loading in various components - Added a silent error handling mechanism for specific URLs in the HTTP request module to suppress error messages. - Refactored data loading logic in sceneConfig.vue to load configuration data based on the selected tab, improving user experience. - Updated YAMLView.vue and other components to remove unused button code and optimize imports, enhancing code clarity and maintainability. - Improved error handling in routingRule and dynamicConfig components to ensure better user feedback and debugging. * feat: add new components and enhance YAML and XML editing capabilities - Introduced new JavaScript files for YAML and XML syntax highlighting and editing. - Added components for updating YAML configurations with structured editor interfaces. - Updated index.html to reference new JavaScript bundles for improved functionality. - Enhanced error handling and logging in various components for better debugging. - Removed unused code and optimized imports in YAMLView and related components. * feat: enhance UI components and improve error handling - Added global styles for clickable links in tables to improve user interaction. - Updated routing logic to utilize a dynamic header parameter key for better flexibility. - Enhanced error handling in HTTP requests to suppress messages for specific URLs. - Improved internationalization by adding new translation keys for 'Ready Time' in both English and Chinese. - Refactored various components to optimize code structure and maintainability, including updates to YAML and form views. - Adjusted table and form layouts for better responsiveness and user experience. * refactor: streamline component code and enhance condition handling - Simplified iframe rendering in GrafanaPage.vue for improved readability. - Added checks in ConfigModel.ts to skip undefined keys in matches and parameters. - Optimized YAMLView.vue by condensing MonacoEditor properties for better clarity. - Cleared default request and address matching arrays in formView.vue for cleaner initialization. - Enhanced condition parsing and merging logic in updateByFormView.vue to improve maintainability and readability. * build: build admin * fix: improve error handling and UI updates in GrafanaPage and sceneConfig components - Added conditional checks in GrafanaPage.vue to ensure valid baseURL before constructing the Grafana URL. - Enhanced iframe loading logic to prevent errors when accessing undefined elements. - Updated service.vue to handle potential undefined values in versionGroups, ensuring robust data handling. - Refactored sceneConfig.vue to improve the user experience by adding a conditional rendering for parameter routes, including a message for empty configurations and a button for adding new routes. * refactor: Request to update the Grafana URL * build: build * ♻️ refactor: update route parameters to include name and make pathId/appName optional Update routing structure across instance and traffic management views to: - Add :name parameter to routes for better identification - Make :pathId and :appName optional parameters (with ?) - Affects instance detail, monitor, link tracking, and configuration tabs - Updates dynamic config, routing rule, and tag rule views accordingly This change provides more flexible routing and better resource identification. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * ✨ feat(routing): add routing rule list component and composable Add new RoutingRuleList component and useRoutingRule composable to manage routing rule configurations. Updates addByFormView and updateByFormView to integrate with the new components. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * build: format & build * ✨ feat(routing): enhance routing rule form with comprehensive i18n support Enhance routing rule form functionality with improved internationalization, user interface refinements, and better form handling. - Add comprehensive i18n translations for routing rule fields - Improve form layout and field descriptions - Enhance routing rule list component with better UX - Refactor routing rule composable for better maintainability - Update tab header slots for improved navigation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * build: format & build --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * Fix/console (#1397) * fix: create tag rule bug * refactor: config refactor; fix: fix console bugs * fix: instance disable traffic * fix: CI promblems * fix: typo * fix(ui): update footer copyright year to 2026 (#1396) * implement counter by key (#1390) * implement counter by key * chore: trigger CI * Fix counter initialization errors and mesh change detection logic --------- Co-authored-by: WyRainBow <your-email@example.com> * feat: kubernetes deployment manifests and docker file (#1410) * refactor: refactor dockerfile and implement dubbo-admin deployment * fix: deploy manifests * rm: remove useless files (#1416) * feat: implement distributed lock by gorm (#1432) * feat: add leader election for Discovery, Engine, Counter.(#1423) * feat: add leader election for Discovery and Engine components * fix: separate renew/acquire SQL and stop informers on demotion * feat: add leader election for Counter component * fix: resolve copilot review suggestion * fix: GormStore.Pool return value * Feat: Enhance service method retrieval and invocation features (#1429) * feat: add endpoint to retrieve service method names and corresponding request model * feat: add endpoint and logic to retrieve service method details * feat: trim whitespace from service name, mesh, group, version, and provider app name in ServiceMethodsReq * feat: enhance service method handling with overload support and signature retrieval * feat: add generic service invocation support * feat: refactor triple RPC instance selection to use a dedicated target struct * feat: remove obsolete service methods test file * feat: improve error handling in generic service invocation and add parameter count validation * feat: remove unnecessary variable and directly call service.InvokeServiceGeneric in ServiceGenericInvoke * feat: improve query validation by using strutil for blank checks and enhance service provider metadata indexing * feat: add endpoint to retrieve service provider instances and enhance request validation * feat: update service provider instance handling and improve request validation * feat: enhance generic service invocation with protocol and serialization support * feat: add normalization functions for JSON values in generic service invocation * feat: add normalization functions for JSON values in generic service invocation * feat: refine retry logic for service invocation failures * feat(ui-vue3): 添加 mock 数据支持，优化请求配置 - 添加环境变量 `VITE_MOCK_ENABLED` 用于启用 mock 数据模式 - 更新 `package.json` 脚本以添加 `dev:mock` 用于 mock 数据开发环境 - 新增 `mockLogin.ts` 文件，提供 mock 登录和登出接口 - 修改 `request.ts`，根据环境变量切换请求的 `baseURL` - 优化 `main.ts`，根据 mock 模式自动导入 mock API 并更新认证状态 * feat(ui-vue3): 新增 Axios 依赖和 mock 数据接口 - 新增 axios 作为 HTTP 客户端依赖 - 优化 mock 数据接口，包括应用指标、流量权重、灰度配置等 - 更新 package.json 文件以添加 axios 依赖 - 修改多个 mock 接口以适应新的架构和数据结构 * feat(api): 新增 mock 服务方法列表、详情及泛化调用接口 * feat(api): add front func * feat(ui-vue3): improve func empty description * feat(ui-vue3): code format * feat(api): update mock interface * feat(ui-vue3): add elapsed time display for service debug invoke * refactor: replace mockjs with MSW for API mocking Migrate from mockjs to Mock Service Worker (MSW) for a more realistic mock setup that intercepts at the network level. This eliminates the need for a separate mock baseURL and simplifies the mock architecture. - Remove mockjs dependency and all src/api/mock/* files - Add msw with browser worker and handler-based mock definitions - Move mock data to src/mocks/ with per-domain handler organization - Add shared API type definitions in src/types/api.ts - Simplify request.ts baseURL (always /api/v1, MSW handles interception) - Update main.ts mock initialization to use MSW worker * feat(api): refactor service request handling to use BaseServiceReq * feat(api): simplify service provider metadata lookup logic * feat(api): streamline service method resolution and metadata handling * feat(api): enhance ServiceGenericInvokeReq structure and streamline metadata handling * style(debug): format icon imports for improved readability * refactor(api): simplify splitGenericArrayType function by removing redundant checks * chore(deps): downgrade msw and related dependencies to version 2.11.6 * style(debug): improve debug tab UI with typography components and refined styles * style(debug): refine button and typography styles for improved consistency --------- Co-authored-by: 劳资蜀道山 <1493170339@qq.com> * feat: extend indexer with prefix matching and db persistence (#1422) * feat: extend indexer with prefix matching and db persistence * refactor: remove in-memory index from GormStore and add operator field * fix: copilot review suggestion and service panic * update * feat: unify and enhance the lifecycle of an instance (#1440) * feat: add lifecycle state management and color coding for instance statuses * feat: enhance instance lifecycle management with state derivation and UI updates * feat: improve resource handling in informer with enhanced error reporting * feat: enhance instance lifecycle logging with detailed merge and delete events * feat: implement ResourceKeyProvider interface for consistent key generation in informers * refactor: refactor instance resource handling and key function resolution in informers * refactor: remove unused deployState and registerState columns from instance table * feat: enhance runtime instance retrieval with improved matching logic and fallback handling * feat: improve runtime instance identification with enhanced error logging and filtering * feat: add pod watch selector and RPC port identifiers for improved service configuration * feat: add refresh button and localization support for improved user interaction * fix: fix lint * feat: enhance runtime instance retrieval with improved fallback handling and logging for ambiguous matches * fix: enhance instance lifecycle and deployment state management with new types and improved data handling * feat(eventbus): support per-subscriber async dispatch with graceful drain (#1455) * feat(eventbus): support per-subscriber async dispatch with graceful drain * refactor(config): unify AdminConfig method receivers as pointers * refactor(eventbus): move AsyncEnabled into Subscriber with docs * fix(config): keep read-only helpers on value receiver * refactor(config): unify AdminConfig receiver style * feat(mcp): add Model Context Protocol (MCP) server with HTTP transport and authentication ## Summary Implement Model Context Protocol (MCP) server for Dubbo Admin to enable AI integration through standardized tool interfaces. ## Key Features - **Modular Architecture**: Core components (server, registry, tools, transport, types) - **Comprehensive Tool Support**: 11 tools covering cluster info, service discovery, instance management, metrics, and application details - **Dual Transport Support**: - Stdio transport for local Claude Desktop integration - HTTP transport for remote connections with JSON-RPC 2.0 - **Security**: Optional Bearer Token authentication for HTTP endpoint ## Configuration ## Test plan - [x] Unit tests for core components - [x] Integration tests - [x] Manual testing with Claude Desktop Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Service/Application Dependency Graph Implement (#1460) * feat(ui): Added application and service topology mapping feature * style(ui-vue3): Add a minimum width to the login form and remove unnecessary blank lines * Feat: Add service and application topology graph APIs based on discussion #1398 * feat(api): add GraphServices endpoint for service-level topology Based on discussion #1398, use ServiceProviderMetadata and ServiceConsumerMetadata to return provider/consumer application relations as graph nodes and edges for AntV G6. * feat(api): add GraphApplications endpoint for application-level topology Traverse provider/consumer service relations to build application-level graph. Also add idx_service_consumer_service_key index to support efficient serviceKey queries. * feat(api): add graph models (GraphNode, GraphEdge, GraphData) in pkg/console/model/graph.go * feat(api): add ApplicationGraphReq, ServiceGraphReq and GetApplicationGraph, GetServiceGraph handlers * feat(router): register /application/graph and /service/graph routes * feat(api): fix error handling to use direct err pass-through instead of MeshNotFoundError * Feat: Enhance service metadata derivation and detail retrieval ([#1430](#1430)) * feat(api): replace Service.{providers,consumers,features} with {methods} field Simplify Service proto by removing providers, consumers, and features map, keeping only the aggregated methods list derived from provider metadata. * feat(api): derive Service resource from ServiceProviderMetadata on add/update/delete ServiceProviderMetadataEventSubscriber now maintains Service resources by aggregating methods from all provider instances sharing the same serviceKey. Handles add, update, and delete events to keep Service spec in sync. * feat(api): add language detection from provider metadata parameters Detect provider language (golang/java) from metadata parameters and method type signatures when explicit language field is absent. * feat(api): add GetServiceDetail endpoint returning language and methods Add GET /service/detail returning ServiceDetailResp with language and aggregated method names from the derived Service resource. * feat(api): add BuildServiceIdentityKey helper for {service}:{version}:{group} * feat(api): add ByServiceName index for ServiceKind * feat(api): refactor SearchServices to query ServiceResource directly SearchServices and SearchServicesByKeywords now use ServiceResource instead of ServiceProviderMetadataResource for service listing. * feat(api): remove providerAppName from ServiceSearchResp and ServiceTabDistributionReq * feat(api): add ServiceDetailReq and ServiceDetailResp models * feat(router): register /service/detail and /service/interfaces routes * feat(ui-vue3): remove providerAppName from grafana types and tab components * chore: Add G6 chart library and its dependencies to the project * chore(assets): Add Apache license and format code for iconfont file * fix: Correct the naming errors in the application topology graph API parameters and improve the code comments * chore: minor cleanup - fix comment language and import order * chore: translate Chinese comment to English in GraphApplications error handling * chore: reorder imports in service_provider_metadata.go * fix:Fix parameter passing error when obtaining application details * fix: fix type mismatch and index issues in service search and metadata sync 1. pkg/console/service/service.go:132 - fix generic type mismatch with resourceKind - generic ServiceResource should use ServiceKind, was incorrectly passing ServiceProviderMetadataKind - index changed from ByServiceProviderServiceName to ByServiceName (aligned with ServiceKind) 2. pkg/core/discovery/subscriber/service_provider_metadata.go - processUpdate: remove redundant oldRes key check (oldKey always equals newKey in same resource update, else branch is unreachable dead code) - syncService: use ByServiceProviderServiceKey index instead of ByServiceProviderServiceName + manual version/group filtering, reduces data returned from DB and improves performance Ref: [1460](#1460 (comment)) * Feat: Add coding agent domain skills ([#1457](#1457)) * feat(skills): add backend domain skills for runtime, discovery, engine, events, store, and Console API Document component lifecycle, ListAndWatch discovery, resource engine behavior, EventBus dispatching, storage indexes, and Web MVC flow for coding agents. * feat(skills): add frontend domain skill for routing, components, and traffic rule forms Document Vue frontend structure, API clients, Pinia state, route metadata, layout tabs, and traffic rule form design. * feat(skills): add OpenAI skill metadata Add agents/openai.yaml metadata for each dubbo-admin domain skill. * fix(console): use ServiceKind for service list search Query ServiceResource from ServiceKind instead of ServiceProviderMetadataKind so the non-keyword service list path uses the matching resource store and index set. --------- Co-authored-by: sohandsomejie <3080955413@qq.com> Co-authored-by: MoChengqian <2972013548@qq.com> --------- Co-authored-by: robb <robocanic@gmail.com> Co-authored-by: marsevilspirit <marsevilspirit@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: WyRainBow <weiyu9484@gmail.com> Co-authored-by: LGgbond <1493170339@qq.com> Co-authored-by: Helltab <939255879@qq.com> Co-authored-by: Tew <finntew@outlook.com> Co-authored-by: EVERFID <166227111+everfid-ever@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Akshit Vig <akshitvig48@gmail.com> Co-authored-by: WyRainBow <your-email@example.com> Co-authored-by: EVERFID <3085640487@qq.com> Co-authored-by: ThunGuo <tew@apache.org> Co-authored-by: Zerui Yang <zeruiyoung@gmail.com> Co-authored-by: LunaRain_079 <2074730050@qq.com> Co-authored-by: Comrade Yi <119987662+ambiguous-pointer@users.noreply.github.com> Co-authored-by: sohandsomejie <3080955413@qq.com> Co-authored-by: MoChengqian <2972013548@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ##1338