Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dubbogo version: 3.1.0 #603

Closed
wants to merge 0 commits into from
Closed

Conversation

hookokoko
Copy link

@hookokoko hookokoko commented Dec 24, 2023

What this PR does: upgrage dubbogo to 3.1.0

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
应该还要依赖dubbogo的一些修改

  1. 依赖的dubbogo的health.proto的pakagename冲突(protocol/triple/health/triple_health/health.proto)
  2. dubbogo中的registryUrl.Protocol的问题(registry/protocol/protocol.go)
    Does this PR introduce a user-facing change?:

@hookokoko
Copy link
Author

func (proto *registryProtocol) Refer(url *common.URL) protocol.Invoker {
	......
	if registryUrl.Protocol == constant.RegistryProtocol {
		registryUrl.Protocol = registryUrl.GetParam(constant.RegistryKey, "")
	}
        ......

在跑pixiu sample中的body例子时,dubbogo
3.1.0版本中会将registryUrl.Protocol设置为service-discovery-registry,上面if分支中应该需要额外一个判断:
if registryUrl.Protocol == constant.RegistryProtocol || registryUrl.Protocol == "service-discovery-registry" {...}
不然找不到registry对象

@AlexStocks AlexStocks requested review from mark4z and baerwang and removed request for mark4z December 24, 2023 10:51
@@ -24,7 +24,7 @@ import (
)

import (
"dubbo.apache.org/dubbo-go/v3/common/logger"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个没必要改动吧?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用的pixiu日志没问题

@baerwang
Copy link
Member

pls fix ci

@baerwang
Copy link
Member

@baerwang baerwang self-requested a review December 26, 2023 14:37
@hookokoko
Copy link
Author

看下为什么找不到依赖 @hookokoko https://github.com/apache/dubbo-go-pixiu/actions/runs/7323061542/job/19956310498?pr=603

dubbo-pixiu-sample使用的dubbo版本也需要升级一下,3.1.0的dubbogo没dubbo.apache.org/dubbo-go/v3/common/logger

@hookokoko
Copy link
Author

很奇怪,commit的时候看着ci是通过了。不过,按道理integrate test那里应该都过不去哇

@mark4z
Copy link
Member

mark4z commented Jan 7, 2024

@mark4z

@hookokoko hookokoko force-pushed the develop branch 2 times, most recently from cba7fd2 to bbc6a32 Compare January 21, 2024 15:43
@baerwang
Copy link
Member

baerwang commented Feb 4, 2024

pls fix conflicts,bro

Copy link

sonarqubecloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants