feat: migrate registry/polaris #1017
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbchi
force-pushed
the
polaris-register
branch
from
22aa1dd to
1e49020
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Polaris registry example from the compatibility layer (compatibility/polaris/registry/) to the modern API pattern in registry/polaris/, aligning it with other registry examples like Nacos and Zookeeper.
Changes:
- Migrated Polaris registry implementation to use modern Dubbo-go v3 API with
dubbo.NewInstance()pattern instead of legacy config-based approach - Added comprehensive integration tests for Polaris registry functionality
- Updated documentation to reflect the new location and modern usage patterns
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| start_integrate_test.sh | Added registry/polaris to integration test suite |
| registry/polaris/proto/greet.proto | Added protobuf service definition for Greet service |
| registry/polaris/proto/greet.pb.go | Generated protobuf code from greet.proto |
| registry/polaris/proto/greet.triple.go | Generated Triple protocol code for Greet service |
| registry/polaris/go-server/cmd/server.go | Server implementation using modern API with registry.WithPolaris() |
| registry/polaris/go-client/cmd/client.go | Client implementation using modern API with registry.WithPolaris() |
| registry/polaris/README.md | English documentation for running the example |
| registry/polaris/README-zh.md | Chinese documentation for running the example |
| integrate_test/registry/polaris/tests/integration/registry_test.go | Integration test validating Polaris registry functionality |
| integrate_test/registry/polaris/tests/integration/main_test.go | Test setup and client initialization for integration tests |
| compatibility/polaris/registry/* | Removed legacy config-based implementation files |
| registry/README.md | Added link to Polaris registry example |
| README.md, README_CN.md | Removed references to old compatibility/polaris/registry path |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
AlexStocks
approved these changes
Jan 12, 2026
Contributor
|
@marsevilspirit plz take a look. |
AlexStocks
approved these changes
Jan 13, 2026
Alanxtl
reviewed
Jan 14, 2026
Contributor
There was a problem hiding this comment.
add a language switch btn and rename README-zh to README_CN
中文 | [English](README.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate compatibility/polaris/registry/ to registry/polaris/ using the modern API pattern.
Changes
Move from compatibility/polaris/registry/ to registry/polaris/
Add related integrate test.
#958