feat(async): Add Java interoperability with async RPC support #992

MrSibe · 2025-12-09T06:01:09Z

Overview

Adds Java client and server support to the async module, enabling cross-language async RPC calls between Java and Go over the Triple protocol.

What's New

Java Server: Async service implementation using CompletableFuture
Java Client: Async calls to Go server using CompletableFuture API
Go Client: Updated to call Java server by default
Documentation: Bilingual README with interoperability test scenarios

MrSibe · 2025-12-09T06:15:50Z

Original issue: apache/dubbo-go#3096

MrSibe · 2025-12-09T07:12:00Z

@Alanxtl @CAICAIIs PTAL

MrSibe · 2025-12-09T07:14:22Z

Do I need to modify the integrate test for Java Server and Client?

Alanxtl · 2025-12-09T07:35:45Z

Do I need to modify the integrate test for Java Server and Client?

@MrSibe thanks for your contribution, currently the intergration test doesn't test for java server and client, which we will support it in the future

what we need now is to check the result for go server and client. Checking whether it works as we want

MrSibe · 2025-12-09T11:24:21Z

@Alanxtl
BTW, I saw this issue mentioned do not use time.Sleep in samples. Do I need to fix it in the next commit?

Alanxtl · 2025-12-10T02:33:52Z

@Alanxtl BTW, I saw this issue mentioned do not use time.Sleep in samples. Do I need to fix it in the next commit?

不用，参考这个的实现加好panic判断行为是否符合预期就行了 #985

Alanxtl · 2025-12-20T03:40:42Z

这个推进的怎么样了

MrSibe · 2025-12-20T05:06:50Z

这个推进的怎么样了

这个不是基本完成了吗？再review一下看看还有没有需要完善的地方？

Alanxtl

lgtm

Copilot

Pull request overview

This PR adds Java client and server support to the async module, enabling cross-language async RPC calls between Java and Go over the Triple protocol. The implementation demonstrates bidirectional interoperability where Java clients can call Go servers and vice versa.

Key changes:

Updates proto package name from user to org.apache.dubbo.samples.async.proto for Java compatibility
Adds Java server and client modules with Maven configuration for building protobuf stubs
Implements async RPC using CompletableFuture in Java and existing Go async patterns

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
async/proto/user.proto	Updates package name to fully-qualified Java package and adds Java-specific options (java_package, java_multiple_files, java_outer_classname) for code generation
async/proto/user.triple.go	Regenerated Go stubs with updated service names reflecting the new proto package name
async/proto/user.pb.go	Regenerated Go protobuf code using newer protoc-gen-go version with structural changes
async/pom.xml	Parent POM defining shared dependencies, plugin configurations, and protobuf compilation setup
async/java-server/pom.xml	Java server module configuration with Dubbo and protobuf dependencies
async/java-server/src/main/java/org/apache/dubbo/samples/async/JavaAsyncServer.java	Java async server implementation using CompletableFuture with two service implementations (UserProvider and UserProviderV2)
async/java-server/run.sh	Shell script to build and run the Java server on port 50051
async/java-client/pom.xml	Java client module configuration mirroring server dependencies
async/java-client/src/main/java/org/apache/dubbo/samples/async/JavaAsyncClient.java	Java async client implementation demonstrating async calls to Go server using CompletableFuture callbacks
async/java-client/run.sh	Shell script to build and run the Java client connecting to Go server on port 20000
async/README.md	Updated documentation describing Java-Go interoperability test scenarios and setup instructions
async/README_zh.md	Chinese translation of updated documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-24T04:14:23Z

async/README.md

+1. **Modify the Go client URL** in `go-client/cmd/main.go`:
+
+   ```go
+   client.WithClientURL("tri://127.0.0.1:50051"),
+   ```


The documentation states that the Go client can be modified to connect to the Java server by changing the URL to "tri://127.0.0.1:50051", but the actual Go client code in go-client/cmd/main.go currently hardcodes "tri://127.0.0.1:20000". The README should clarify that this is the default configuration for Go-to-Go communication, and users need to manually change this line in the code to test Java interoperability as described.

@MrSibe Please consider copilot's suggestion.

Copilot · 2025-12-24T04:14:24Z

async/README_zh.md

+1. **修改 Go 客户端 URL**，在 `go-client/cmd/main.go` 中修改：
+
+   ```go


The documentation states that the Go client can be modified to connect to the Java server by changing the URL to "tri://127.0.0.1:50051", but the actual Go client code in go-client/cmd/main.go currently hardcodes "tri://127.0.0.1:20000". The README should clarify that this is the default configuration for Go-to-Go communication, and users need to manually change this line in the code to test Java interoperability as described.

Suggested change

1. **修改 Go 客户端 URL**，在 `go-client/cmd/main.go` 中修改：

```go

1. **修改 Go 客户端 URL**。Go 客户端默认配置为连接 Go 服务端（端口 `20000`），在 `go-client/cmd/main.go` 中通常如下：

```go

client.WithClientURL("tri://127.0.0.1:20000"),

为了让 Go 客户端连接到 Java 服务端，请将上述行修改为：

Copilot · 2025-12-24T04:14:25Z

async/pom.xml

+    <properties>
+        <protobuf.version>3.21.7</protobuf.version>


The protobuf version specified is 3.21.7, but the generated Go code (user.pb.go line 20) indicates it was generated with protoc v6.33.1. This version mismatch between the Maven configuration and the actual protoc version used could lead to inconsistencies. Consider updating the protobuf.version property to match the version of protoc that will be used to generate the code, or document which version should be used for consistency across Go and Java code generation.

Suggested change

<properties>

<protobuf.version>3.21.7</protobuf.version>

<properties>



<protobuf.version>3.21.7</protobuf.version>



<go.protoc.version>6.33.1</go.protoc.version>

Copilot · 2025-12-24T04:14:25Z

async/java-client/src/main/java/org/apache/dubbo/samples/async/JavaAsyncClient.java

+        future2.whenComplete((response, throwable) -> {
+            if (throwable == null) {
+                System.out.println("sayHello completed");
+            }
+            latch2.countDown();
+        });


The error handling for the second async call (sayHelloAsync) is inconsistent with the first. The callback at line 68-73 only checks if throwable is null and prints "sayHello completed", but it doesn't handle or log the error case when throwable is not null. This means errors in the SayHello call will be silently ignored. Consider adding error handling similar to the first callback to ensure errors are properly logged.

Copilot · 2025-12-24T04:14:26Z

async/proto/user.proto

 syntax = "proto3";

-package user;
+package org.apache.dubbo.samples.async.proto;


The proto package name has been changed from "user" to "org.apache.dubbo.samples.async.proto" for Java interoperability. While this is intentional for cross-language compatibility, it's important to note that this is a breaking change for any existing clients or servers using the old package name. The change appears in the generated service names and should be coordinated across all implementations.

Suggested change

package org.apache.dubbo.samples.async.proto;

package user;

AlexStocks · 2025-12-27T08:38:10Z

把 copilot 的review 结果看下哈

AlexStocks · 2026-01-13T11:06:46Z

@MrSibe Please review the copilot's comment.

MrSibe added 6 commits December 9, 2025 13:35

feat(async): add Java support for proto and Maven configuration

ffe31d2

feat(async): implement Java async server

7b833d8

feat(async): implement Java async client

31b72a6

docs(async): update README for Java-Go interoperability

312aed6

fix(async): update proto generation comments and regenerate pb.go

80e885a

docs(async): improve documentation and change default port

4f25a10

Alanxtl approved these changes Dec 24, 2025

View reviewed changes

AlexStocks requested a review from Copilot December 24, 2025 04:04

Copilot started reviewing on behalf of AlexStocks December 24, 2025 04:05 View session

Copilot AI reviewed Dec 24, 2025

View reviewed changes

		1. 修改 Go 客户端 URL，在 `go-client/cmd/main.go` 中修改：

		```go

-. **修改 Go 客户端 URL**，在 `go-client/cmd/main.go` 中修改：
-   ```go
+. **修改 Go 客户端 URL**。Go 客户端默认配置为连接 Go 服务端（端口 `20000`），在 `go-client/cmd/main.go` 中通常如下：
+   ```go
+   client.WithClientURL("tri://127.0.0.1:20000"),

feat(async): Add Java interoperability with async RPC support #992

Are you sure you want to change the base?

feat(async): Add Java interoperability with async RPC support #992

Uh oh!

Conversation

MrSibe commented Dec 9, 2025

Overview

What's New

Uh oh!

MrSibe commented Dec 9, 2025

Uh oh!

MrSibe commented Dec 9, 2025

Uh oh!

MrSibe commented Dec 9, 2025

Uh oh!

Alanxtl commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MrSibe commented Dec 9, 2025

Uh oh!

Alanxtl commented Dec 10, 2025

Uh oh!

Alanxtl commented Dec 20, 2025

Uh oh!

MrSibe commented Dec 20, 2025

Uh oh!

Alanxtl left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

AlexStocks Dec 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

AlexStocks commented Dec 27, 2025

Uh oh!

AlexStocks commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alanxtl commented Dec 9, 2025 •

edited

Loading