Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions client/action.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,6 @@ func (refOpts *ReferenceOptions) refer(srv common.RPCService, info *ClientInfo)
common.WithAttribute(constant.TripleConfigKey, ref.ProtocolClientConfig.TripleConfig),
common.WithAttribute(constant.TLSConfigKey, refOpts.TLS),

// for new triple non-IDL mode
// TODO: remove ISIDL after old triple removed
common.WithParamsValue(constant.IDLMode, ref.IDLMode),
common.WithAttribute(constant.ApplicationKey, refOpts.Application),
common.WithAttribute(constant.ShutdownConfigPrefix, refOpts.Shutdown),
common.WithAttribute(constant.ConsumerConfigKey, refOpts.Consumer),
Expand Down
2 changes: 0 additions & 2 deletions client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection
interfaceName := common.GetReference(service)

finalOpts := []ReferenceOption{
WithIDL(constant.NONIDL),
// default msgpack serialization
WithSerialization(constant.MsgpackSerialization),
}
Expand All @@ -146,7 +145,6 @@ func (cli *Client) NewService(service any, opts ...ReferenceOption) (*Connection
// result, err := genericService.Invoke(ctx, "QueryUser", []string{"org.apache.dubbo.samples.User"}, []hessian.Object{user})
func (cli *Client) NewGenericService(referenceStr string, opts ...ReferenceOption) (*generic.GenericService, error) {
finalOpts := []ReferenceOption{
WithIDL(constant.NONIDL),
WithGeneric(),
WithSerialization(constant.Hessian2Serialization),
}
Expand Down
7 changes: 0 additions & 7 deletions client/options.go
Original file line number Diff line number Diff line change
Expand Up @@ -375,13 +375,6 @@ func WithSticky() ReferenceOption {
}
}

// TODO: remove this function after old triple removed
func WithIDL(IDLMode string) ReferenceOption {
return func(opts *ReferenceOptions) {
opts.Reference.IDLMode = IDLMode
}
}

// ========== Protocol to consume ==========

func WithProtocolDubbo() ReferenceOption {
Expand Down
10 changes: 0 additions & 10 deletions common/constant/key.go
Original file line number Diff line number Diff line change
Expand Up @@ -68,22 +68,12 @@ const (
KeepAliveInterval = "keep-alive-interval"
KeepAliveTimeout = "keep-alive-timeout"

// TODO: remove IDLMode after old triple removed
IDLMode = "IDL-mode"

TripleConfigKey = "triple-config"
ConsumerConfigKey = "consumer-config"
RegistriesConfigKey = "registries-config"
RoutersConfigKey = "routers-config"
)

// TODO: remove this after old triple removed
// IDLMode
const (
IDL = "IDL"
NONIDL = "non-IDL"
)

// tls constant
const (
TLSKey = "tls_key"
Expand Down
5 changes: 0 additions & 5 deletions global/reference_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ type ReferenceConfig struct {
// remove KeepAliveInterval and KeepAliveInterval in version 4.0.0
KeepAliveInterval string `yaml:"keep-alive-interval" json:"keep-alive-interval,omitempty" property:"keep-alive-interval"`
KeepAliveTimeout string `yaml:"keep-alive-timeout" json:"keep-alive-timeout,omitempty" property:"keep-alive-timeout"`

// just for new triple non-IDL mode
// TODO: remove IDLMode when config package is removed
IDLMode string
}

func DefaultReferenceConfig() *ReferenceConfig {
Expand Down Expand Up @@ -202,7 +198,6 @@ func (c *ReferenceConfig) Clone() *ReferenceConfig {
MeshProviderPort: c.MeshProviderPort,
KeepAliveInterval: c.KeepAliveInterval,
KeepAliveTimeout: c.KeepAliveTimeout,
IDLMode: c.IDLMode,
}
}

Expand Down
19 changes: 0 additions & 19 deletions protocol/dubbo3/doc.go

This file was deleted.

61 changes: 0 additions & 61 deletions protocol/dubbo3/dubbo3_exporter.go

This file was deleted.

Loading
Loading