refactor: converge protocol and triple configuration models - #3613
refactor: converge protocol and triple configuration models#3613EmptyCity-111 wants to merge 3 commits into
Quality Gate passed
Annotations
Check warning on line 43 in tools/benchmark/client/engine/engine.go
sonarqubecloud / SonarCloud Code Analysis
Remove this 'context.Context' field and pass context as a parameter to methods that need it.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKT0U0-DRbDE3DXg&open=AZ_rfKT0U0-DRbDE3DXg&pullRequest=3613
Check warning on line 73 in tools/benchmark/client/main.go
sonarqubecloud / SonarCloud Code Analysis
Extract this nested anonymous struct into a named type for better readability and reusability.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKURU0-DRbDE3DXh&open=AZ_rfKURU0-DRbDE3DXh&pullRequest=3613
Check warning on line 29 in tools/benchmark/client/clients/dubbo_client.go
sonarqubecloud / SonarCloud Code Analysis
Add a comment explaining why this blank import is needed.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKUpU0-DRbDE3DXi&open=AZ_rfKUpU0-DRbDE3DXi&pullRequest=3613
Check failure on line 59 in tools/benchmark/scripts/run_all.sh
sonarqubecloud / SonarCloud Code Analysis
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVIU0-DRbDE3DXl&open=AZ_rfKVIU0-DRbDE3DXl&pullRequest=3613
Check warning on line 425 in protocol/triple/server.go
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this TODO comment.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKNKU0-DRbDE3DXc&open=AZ_rfKNKU0-DRbDE3DXc&pullRequest=3613
Check warning on line 140 in protocol/triple/client.go
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this TODO comment.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKOFU0-DRbDE3DXf&open=AZ_rfKOFU0-DRbDE3DXf&pullRequest=3613
Check failure on line 29 in tools/benchmark/scripts/run_single.sh
sonarqubecloud / SonarCloud Code Analysis
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVqU0-DRbDE3DXo&open=AZ_rfKVqU0-DRbDE3DXo&pullRequest=3613
Check failure on line 51 in tools/benchmark/scripts/run_single.sh
sonarqubecloud / SonarCloud Code Analysis
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVqU0-DRbDE3DXp&open=AZ_rfKVqU0-DRbDE3DXp&pullRequest=3613
Check warning on line 133 in tools/benchmark/scripts/run_all.sh
sonarqubecloud / SonarCloud Code Analysis
Redirect this error message to stderr (>&2).
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVIU0-DRbDE3DXm&open=AZ_rfKVIU0-DRbDE3DXm&pullRequest=3613
Check failure on line 33 in tools/benchmark/scripts/run_all.sh
sonarqubecloud / SonarCloud Code Analysis
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVIU0-DRbDE3DXj&open=AZ_rfKVIU0-DRbDE3DXj&pullRequest=3613
Check failure on line 38 in tools/protoc-gen-triple-openapi/internal/converter/convert_test.go
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKW4U0-DRbDE3DXv&open=AZ_rfKW4U0-DRbDE3DXv&pullRequest=3613
Check warning on line 552 in protocol/triple/server.go
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this TODO comment.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKNKU0-DRbDE3DXd&open=AZ_rfKNKU0-DRbDE3DXd&pullRequest=3613
Check warning on line 87 in tools/benchmark/scripts/run_single.sh
sonarqubecloud / SonarCloud Code Analysis
Redirect this error message to stderr (>&2).
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVqU0-DRbDE3DXq&open=AZ_rfKVqU0-DRbDE3DXq&pullRequest=3613
Check warning on line 672 in protocol/triple/server.go
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this TODO comment.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKNKU0-DRbDE3DXe&open=AZ_rfKNKU0-DRbDE3DXe&pullRequest=3613
Check warning on line 126 in filter/accesslog/file_handle_test.go
sonarqubecloud / SonarCloud Code Analysis
Remove this unnecessary variable declaration and use the expression directly in the condition.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKDsU0-DRbDE3DXb&open=AZ_rfKDsU0-DRbDE3DXb&pullRequest=3613
Check warning on line 143 in tools/benchmark/scripts/run_all.sh
sonarqubecloud / SonarCloud Code Analysis
Redirect this error message to stderr (>&2).
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVIU0-DRbDE3DXn&open=AZ_rfKVIU0-DRbDE3DXn&pullRequest=3613
Check warning on line 117 in tools/benchmark/scripts/run_single.sh
sonarqubecloud / SonarCloud Code Analysis
Redirect this error message to stderr (>&2).
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVqU0-DRbDE3DXs&open=AZ_rfKVqU0-DRbDE3DXs&pullRequest=3613
Check failure on line 38 in tools/benchmark/proto/benchmark.triple.go
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "benchmark.BenchmarkService" 4 times.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKWiU0-DRbDE3DXu&open=AZ_rfKWiU0-DRbDE3DXu&pullRequest=3613
Check warning on line 49 in tools/benchmark/scripts/run_all.sh
sonarqubecloud / SonarCloud Code Analysis
Redirect this error message to stderr (>&2).
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVIU0-DRbDE3DXk&open=AZ_rfKVIU0-DRbDE3DXk&pullRequest=3613
Check warning on line 108 in tools/benchmark/scripts/run_single.sh
sonarqubecloud / SonarCloud Code Analysis
Redirect this error message to stderr (>&2).
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKVqU0-DRbDE3DXr&open=AZ_rfKVqU0-DRbDE3DXr&pullRequest=3613
Check warning on line 35 in tools/benchmark/server/dubbo-go/main.go
sonarqubecloud / SonarCloud Code Analysis
Add a comment explaining why this blank import is needed.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_rfKWGU0-DRbDE3DXt&open=AZ_rfKWGU0-DRbDE3DXt&pullRequest=3613
Check failure on line 142 in instance_options_init.go
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=apache_dubbo-go&issues=AZ_lHHeS0FCPfX5GVHYy&open=AZ_lHHeS0FCPfX5GVHYy&pullRequest=3613