-
Notifications
You must be signed in to change notification settings - Fork 26.5k
fix potential Netty IO blocking in TripleProtocol connection handling… #15283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.3
Are you sure you want to change the base?
fix potential Netty IO blocking in TripleProtocol connection handling… #15283
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15283 +/- ##
=============================================
- Coverage 60.75% 35.59% -25.17%
+ Complexity 10917 10859 -58
=============================================
Files 1886 1886
Lines 86097 86112 +15
Branches 12896 12896
=============================================
- Hits 52310 30653 -21657
- Misses 28333 50981 +22648
+ Partials 5454 4478 -976
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @iJIAJIA, @AlbumenJ, @JunJieLiu51520 could you please take a look and let me know if there are any further changes I should make? One of the CI tests is currently failing because it depends on a separate PR. |
<maven.compiler.source>17</maven.compiler.source> | ||
<maven.compiler.target>17</maven.compiler.target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not change this
… #13041
What is the purpose of the change?
This PR fixes Netty IO blocking in TripleProtocol's NettyConnectionClient to prevent client-side request timeouts and improve stability when using the triple protocol.
Checklist