Fix: Stabilize ExtensionLoaderTest.testInjectExtension #15744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
This PR fixes order-dependent flakiness (OD-Vic) in
ExtensionLoaderTest.testInjectExtensionThis test fails under randomized test execution orders due to multiple DemoImpl instances being registered in the shared ScopeBeanFactory of ApplicationModel.
Root Cause
testInjectExtensionand related tests (testGetOrDefaultExtension) both interacted with the same sharedScopeBeanFactory.Because bean registration was not idempotent, repeated or parallel test execution sometimes resulted in duplicate
DemoImplentries, leading to inconsistent injection results or assertion failures.What's Changed
These changes eliminate shared-state interference and make the test deterministic under any order or random seed.
Verification
You can try running the loop below on pre-fix and post-fix code:
The seeds were found by using a script I developed locally. Sometimes not all seeds fail on execution, but some will always fail on pre-fix code. However, on post-fix code none of the seeds fail.
Checklist