Skip to content

Conversation

@RainYuY
Copy link
Contributor

@RainYuY RainYuY commented Nov 22, 2025

What is the purpose of the change?

fix #15752

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.76%. Comparing base (d879176) to head (1c75bff).
⚠️ Report is 38 commits behind head on 3.3.

Files with missing lines Patch % Lines
.../dubbo/qos/command/decoder/HttpCommandDecoder.java 58.82% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15788      +/-   ##
============================================
- Coverage     61.04%   60.76%   -0.29%     
+ Complexity    11702    11693       -9     
============================================
  Files          1923     1938      +15     
  Lines         87069    88649    +1580     
  Branches      13112    13380     +268     
============================================
+ Hits          53152    53864     +712     
- Misses        28476    29257     +781     
- Partials       5441     5528      +87     
Flag Coverage Δ
integration-tests-java21 32.37% <0.00%> (-0.55%) ⬇️
integration-tests-java8 32.45% <0.00%> (-0.51%) ⬇️
samples-tests-java21 31.99% <0.00%> (-0.61%) ⬇️
samples-tests-java8 29.73% <0.00%> (-0.61%) ⬇️
unit-tests-java11 59.04% <58.82%> (+0.04%) ⬆️
unit-tests-java17 58.56% <58.82%> (-0.19%) ⬇️
unit-tests-java21 58.56% <58.82%> (-0.21%) ⬇️
unit-tests-java25 58.50% <58.82%> (?)
unit-tests-java8 59.08% <58.82%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@zrlw zrlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RainYuY RainYuY merged commit 763e8bb into apache:3.3 Nov 23, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]Memory leak in Dubbo QoS module - ByteBuf not released in HttpCommandDecoder

4 participants