Skip to content

Add an agent skill to verify release candidates - #16572

Open
oxsean wants to merge 1 commit into
apache:3.3from
oxsean:release-vote-check-skill
Open

oxsean wants to merge 1 commit into
apache:3.3from
oxsean:release-vote-check-skill

Conversation

@oxsean

@oxsean oxsean commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of the change?

Add .agents/skills/release-vote-check, an agent skill that verifies a Dubbo
release candidate before voting and drafts the vote reply.

scripts/verify-rc.sh <version> checks:

  • sha512 and GPG signatures against https://downloads.apache.org/dubbo/KEYS
  • the tag commit equals the commit in the vote email
  • the source package equals the tag tree, except files the source assembly excludes
  • version in pom.xml, empty directories, binary files
  • ASF headers; header-exempt files in .licenserc.yaml must be named in LICENSE
  • LICENSE/NOTICE in each package and the NOTICE year
  • optionally builds the source package (-b)

It writes only under a work directory and uses a temporary GnuPG home.
Tested against the 3.3.7 RC: 0 failures.

.claude/skills links to .agents/skills so Claude Code and Codex share it.

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

- verify-rc.sh checks checksums, signatures, source package vs. tag,
  binary files, license headers, LICENSE/NOTICE and optionally the build
- .claude/skills links to .agents/skills so Claude Code and Codex share it
@codecov-commenter

codecov-commenter commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.98%. Comparing base (2d9730c) to head (7963de7).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16572      +/-   ##
============================================
- Coverage     61.00%   60.98%   -0.03%     
- Complexity       15    11756   +11741     
============================================
  Files          1953     1953              
  Lines         89286    89286              
  Branches      13478    13478              
============================================
- Hits          54471    54449      -22     
- Misses        29213    29231      +18     
- Partials       5602     5606       +4     
Flag Coverage Δ
integration-tests-java21 32.09% <ø> (-0.01%) ⬇️
integration-tests-java8 32.21% <ø> (+0.01%) ⬆️
samples-tests-java21 32.10% <ø> (-0.09%) ⬇️
samples-tests-java8 29.79% <ø> (+<0.01%) ⬆️
unit-tests-java11 59.24% <ø> (-0.02%) ⬇️
unit-tests-java17 58.69% <ø> (-0.02%) ⬇️
unit-tests-java21 58.71% <ø> (-0.04%) ⬇️
unit-tests-java25 58.67% <ø> (ø)
unit-tests-java8 59.25% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants