Skip to content

[codex] Fix treemap parent select fill with upperLabel #21575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
susiwen8 wants to merge 3 commits into
base: master
Choose a base branch
from
+173 −1
Open

[codex] Fix treemap parent select fill with upperLabel #21575

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e316480
fix(treemap): keep parent select fill with upper label
susiwen8 Apr 8, 2026
1e2a3cf
test(treemap): add html upperLabel select case
susiwen8 Apr 10, 2026
24ee0d9
Align treemap HTML regression with parent selection
susiwen8 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/chart/treemap/TreemapView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,12 @@ function renderNode(
const blurStyle = getStateItemStyle(itemStyleBlurModel);
blurStyle.fill = itemStyleBlurModel.get('borderColor');
const selectStyle = getStateItemStyle(itemStyleSelectModel);
selectStyle.fill = itemStyleSelectModel.get('borderColor');
const selectFill = itemStyleSelectModel.get('color');
selectStyle.fill = selectFill != null
? selectFill
: itemStyleSelectModel.get('borderColor') != null
? itemStyleSelectModel.get('borderColor')
: visualBorderColor;

if (useUpperLabel) {
const upperLabelWidth = thisWidth - 2 * borderWidth;
Expand Down
69 changes: 69 additions & 0 deletions test/ut/spec/series/treemap.test.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.