[ISSUE #3009] Method manually handles closing an auto-closeable resource [MetricsHandler] #3547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsm
reviewed
Mar 29, 2023
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/MetricsHandler.java
Outdated
Show resolved
Hide resolved
|
Here you may still have to use try-with-finally, using try-with-resources will be due to the scope of the variable, here in the catch there is out.write(result.getBytes()); this line of code is reported as an error. Do you have a better suggestion? |
1. Used try-with-resources along with nested try-catch to manage resources, fixing out of scope variable. 2. Added similar fix for issue#3007 and issue#3008 to fix compilation error due to out of scope variable in catch block.
mytang0
reviewed
Mar 30, 2023
...mesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/HTTPClientHandler.java
Outdated
Show resolved
Hide resolved
|
Linked to #3544, PR overlapped. @sanskar-thakur |
xwm1992
changed the title
added 3 commits
April 1, 2023 20:53
Used try-with-resources along with nested try-catch to manage resources, fixing out of scope variable.
1. Removed nested try-catch and used single try-with-resources. 2. For out of scope out variable, replaced with log result.
Alonexc
approved these changes
Apr 11, 2023
|
@Pil0tXia this pr seems to be merged after the second reviewer reviews |
|
Please resolve conflicts. |
|
completed in #4800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3009 .
Modifications
Replaced finally block with try-with-resources.
Please include this fix to solve compilation issue occurred due to #3007 and #3008
Documentation