Skip to content

Conversation

@karsonto
Copy link
Member

@karsonto karsonto commented Dec 18, 2023

Fixes #4674

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

wqliang and others added 30 commits July 13, 2023 22:35
…4173)

* resolved the tasks mentioned in issue 4105

* changed declaration from strict to raw type

* resolved checkstyle iussue
…n APIs of dashboard (apache#4210)

* doc: Add JavaDoc for ClientManageController

* doc: Add JavaDoc for HttpHandlerManager

* doc: Add JavaDoc for AbstractHttpHandler

* doc: Add JavaDoc for ConfigurationHandler

* doc: Add JavaDoc for MetricsHandler

* doc: Add JavaDoc for RegistryHandler

* doc: Add JavaDoc for TopicHandler

* doc: Add JavaDoc for EventHandler

* doc: Add JavaDoc for TCPClientHandler

* doc: Add JavaDoc for HTTPClientHandler

* doc: Add JavaDoc for GrpcClientHandler
…etmq Module (apache#4183)

* doc: Write JavaDoc and comments for AdminController

* doc: Write JavaDoc and comments for TopicsHandler

* doc: Write JavaDoc and comments for TopicCreateRequest

* doc: Write JavaDoc and comments for TopicResponse

* doc: Write JavaDoc and comments for RequestMapping

* doc: Write JavaDoc and comments for UrlMappingPattern

* doc: Update JavaDoc of ClientManageController#start

* chore: remove 1 old doc to solve the conflict
…pache#4177)

* Make headerMap and sysHeaderMap transient

* Make public fields private in HttpEventWrapper
…minWebHookConfigOperationManager (apache#4216)

* Optimize: Correct oldAccesssible typos to oldAccessible and add comments

* Optimize: Remove redundant transient keyword
…he#4231)

* support metadata management in http protocol

* fix checkstyle:file format problem

* fix checkstyle problem
…MeshMessageProducer] (apache#4212)

* Update EventMeshMessageProducer.java

Removed stack trace at line 120

* Update EventMeshMessageProducer.java

Removed the `if` statement

* Update EventMeshMessageProducer.java

Fixed indentation at 119
…EN) get null (apache#4225)

* Create .lift.toml

* Update .lift.toml

* Update .lift.toml

* Update .lift.toml

* Update .lift.toml

* Update .lift.toml

* Update .lift.toml

* Update .lift.toml

* Update .lift.toml

* delete lift

* add token field
…er: expected value, actual value: Assert.assertEquals(expected, actual).[ConfigurationHolderTest]
…HookConfigOperationManager (apache#4228)

* Optimize: Use switch...case... and remove redundantly throwed exception.

* fix checkstyle
…o containsValue() (apache#4249)

* Update TcpClient.java

* Update HeatBeatScheduler.java
Added `final` in lines 31,33.
Removed the redundant `null` initialization at lines 48 and 69.
…pache#4235)

* fix: Dereference of 'heartbeatItems' may produce NPE.

* style: code checkstyle.

---------

Co-authored-by: noah.pan <[email protected]>
* fix: Catch Exception instead of Throwable

* style: code checkstyle.

---------

Co-authored-by: noah.pan <[email protected]>
* replace LinkedList by ArrayList

* update import order
* Do some code optimization.[util]

* Do some code optimization.[util]
[ISSUE apache#4065]Make registry plugin Nacos support more configuration items
* [ISSUE apache#4011] add kafkaConnector module

* [ISSUE apache#4011] add kafkaConnector module

* [ISSUE apache#4011] fix codestyle

* Fixes apache#4011.
add default config for kafka sink and source
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karsonto Can you elaborate on the subsequent use of this design? For example, how and where it will be used in detail?

@karsonto
Copy link
Member Author

@karsonto Can you elaborate on the subsequent use of this design? For example, how and where it will be used in detail?

I have reviewed the source code and found that this class is used in many places. Using this class allows you to print exception information in the log of the thread and also to print information about closing the thread pool.

@xwm1992 xwm1992 changed the title [Enhancement] Add a run log for the ThreadPoolExecutor [ISSUE #4674] Add a run log for the ThreadPoolExecutor Dec 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

❌ Patch coverage is 38.97116% with 783 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.37%. Comparing base (1600c6b) to head (ae0b95f).
⚠️ Report is 4691 commits behind head on master.

Files with missing lines Patch % Lines
...mesh/connector/jdbc/connection/JdbcConnection.java 0.00% 137 Missing ⚠️
...va/org/apache/eventmesh/common/utils/LogUtils.java 5.68% 80 Missing and 3 partials ⚠️
...g/apache/eventmesh/common/utils/JsonPathUtils.java 0.00% 54 Missing ⚠️
...tor/jdbc/connection/mysql/MysqlJdbcConnection.java 0.00% 43 Missing ⚠️
...dingtalk/sink/connector/DingDingSinkConnector.java 65.38% 24 Missing and 3 partials ⚠️
...apache/eventmesh/common/LogThreadPoolExecutor.java 0.00% 26 Missing ⚠️
...pache/eventmesh/connector/jdbc/CatalogChanges.java 0.00% 25 Missing ⚠️
...ava/org/apache/eventmesh/connector/jdbc/Field.java 0.00% 24 Missing ⚠️
...ava/org/apache/eventmesh/common/ThreadWrapper.java 59.64% 16 Missing and 7 partials ⚠️
...g/apache/eventmesh/connector/jdbc/DataChanges.java 0.00% 22 Missing ⚠️
... and 71 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4673      +/-   ##
============================================
+ Coverage     16.93%   17.37%   +0.44%     
- Complexity     1413     1759     +346     
============================================
  Files           589      798     +209     
  Lines         25786    29821    +4035     
  Branches       2397     2581     +184     
============================================
+ Hits           4367     5182     +815     
- Misses        20983    24158    +3175     
- Partials        436      481      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the Stale label Apr 15, 2024
@Pil0tXia Pil0tXia added the waiting for contributor PR is awaiting the contributor's response to the review for further evaluation. label Jun 12, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Aug 11, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Oct 17, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Dec 17, 2024
@karsonto karsonto dismissed pandaapo’s stale review February 13, 2025 03:23

The merge-base changed after approval.

@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Apr 14, 2025
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Jun 14, 2025
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Aug 14, 2025
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale waiting for contributor PR is awaiting the contributor's response to the review for further evaluation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Add a run log for the ThreadPoolExecutor