[ISSUE #3833] optimization ZookeeperMetaService#4780
[ISSUE #3833] optimization ZookeeperMetaService#4780mxsm merged 1 commit intoapache:masterfrom Ish1yu:master
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
 |
 |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
| if (CollectionUtils.isEmpty(instances)) { | ||
| continue; | ||
| } | ||
| private void findEventMeshInfo(String tipTitle, String clusterName, |
There was a problem hiding this comment.
I don't think tipTitle is needed here just for logging message.
There was a problem hiding this comment.
There was a problem hiding this comment.
感谢大佬们指点
Thank you for your guidance. My consideration is that the tipTitle here has two values, "findEventMeshInfoByCluster" and "findAllEventMeshInfo", whose call links are executed at different times. If there is an error, I am concerned that it may differ from the previous log printing rules
a. Change to private modifier. b. Repeat code extraction as method.
6 participants
Fixes #3833
Motivation
a. Change to private modifier.
b. Repeat code extraction as method.
Modifications
make public to pravite
Extract public methods
Documentation