Skip to content

Conversation

@kapil-panchal
Copy link

Description

Describe the changes made and why they were made.

This card the plan is to decouple the new command processing infrastructure and push the existing logic to the handlers.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy adamsaghy requested a review from vidakovic September 23, 2025 09:17
@adamsaghy
Copy link
Contributor

adamsaghy commented Sep 23, 2025

@kapil-panchal I appreciate your enthusiasm regarding the work on the "New Command Processing", however before you are opening a new PR, I was wondering whether you could connect with @vidakovic and discuss quickly whether these PRs are aligning with the vision.

@kapil-panchal
Copy link
Author

@kapil-panchal I appreciate your enthusiasm regarding the work on the "New Command Processing", however before you are opening a new PR, I was wondering whether you could connect with @vidakovic and discuss quickly whether these PRs are aligning with the vision.

Sure Adam, I think Aleks is also on the [email protected] email?

@adamsaghy
Copy link
Contributor

@kapil-panchal I appreciate your enthusiasm regarding the work on the "New Command Processing", however before you are opening a new PR, I was wondering whether you could connect with @vidakovic and discuss quickly whether these PRs are aligning with the vision.

Sure Adam, I think Aleks is also on the [email protected] email?

Yes, he is, but also you can reach out to him on Mifos Slack.

@adamsaghy adamsaghy marked this pull request as draft September 23, 2025 14:03
@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants