FINERACT-2326: Loan contract termination same disbursement date #5078
+181
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budaidev
suggested changes
Oct 13, 2025
| loanTransactionHelper.moveLoanState(loanId, | ||
| new PostLoansLoanIdRequest().note("Contract Termination Test").externalId(Utils.randomStringGenerator("", 20)), | ||
| "contractTermination"); | ||
| }); |
There was a problem hiding this comment.
All tests should have some kind of assertions, if we execute these operations what is the expected result?
There was a problem hiding this comment.
@alberto-art3ch Have you addressed this?
alberto-art3ch
force-pushed
the
FINERACT-2326/loan-contract-termination-in-disbursement-date
branch
2 times, most recently
from
09b64cc to
d7add12
Compare
|
@alberto-art3ch Please rebase and take a look on @budaidev's comment |
adamsaghy
force-pushed
the
FINERACT-2326/loan-contract-termination-in-disbursement-date
branch
2 times, most recently
from
9a56a87 to
193d270
Compare
adamsaghy
reviewed
Oct 28, 2025
Comment on lines
133
to
151
| /* | ||
| PostLoanProductsResponse loanProductsResponse = loanProductHelper.createLoanProduct(create4IProgressive().interestRecognitionOnDisbursementDate(false)); | ||
| Long loanId = applyAndApproveProgressiveLoan(client.getClientId(), loanProductsResponse.getResourceId(), "1 January 2024", | ||
| 500.0, 7.0, 6, (request) -> request.interestRecognitionOnDisbursementDate(false)); | ||
| disburseLoan(loanId, BigDecimal.valueOf(100), "1 January 2024"); | ||
| loanTransactionHelper.moveLoanState(loanId, | ||
| new PostLoansLoanIdRequest().note("Contract Termination Test").externalId(Utils.randomStringGenerator("", 20)), | ||
| "contractTermination"); | ||
| verifyTransactions(loanId, // | ||
| transaction(100.0, "Disbursement", "01 January 2024"), // | ||
| transaction(100.0, "Contract Termination", "01 January 2024")); | ||
| GetLoansLoanIdResponse loanDetails = loanTransactionHelper.getLoanDetails(loanId); | ||
| assertEquals(BigDecimal.ZERO.stripTrailingZeros(), | ||
| loanDetails.getSummary().getInterestCharged().stripTrailingZeros()); | ||
| */ |
There was a problem hiding this comment.
@alberto-art3ch Remove if not needed!
There was a problem hiding this comment.
ITC updated, It is required
adamsaghy
force-pushed
the
FINERACT-2326/loan-contract-termination-in-disbursement-date
branch
3 times, most recently
from
daf9a80 to
ccc36cf
Compare
alberto-art3ch
force-pushed
the
FINERACT-2326/loan-contract-termination-in-disbursement-date
branch
from
ccc36cf to
d193a88
Compare
adamsaghy
force-pushed
the
FINERACT-2326/loan-contract-termination-in-disbursement-date
branch
from
d193a88 to
fb90c01
Compare
alberto-art3ch
force-pushed
the
FINERACT-2326/loan-contract-termination-in-disbursement-date
branch
4 times, most recently
from
dc07f34 to
4923088
Compare
PR updated and rebased with develop branch |
alberto-art3ch
force-pushed
the
FINERACT-2326/loan-contract-termination-in-disbursement-date
branch
6 times, most recently
from
c332517 to
149b2ba
Compare
adamsaghy
reviewed
Nov 3, 2025
| transactionDate); | ||
| ProgressiveLoanInterestScheduleModel model = savedModel | ||
| .orElseGet(() -> processor.calculateInterestScheduleModel(loan.getId(), transactionDate)); | ||
| // final LocalDate tillDate = loanApplicationTerms.isInterestRecognitionOnDisbursementDate() ? |
There was a problem hiding this comment.
why is this commented out?
There was a problem hiding this comment.
Done! Commented lines removed those are not needed
adamsaghy
reviewed
Nov 3, 2025
| transactionProcessingStrategyCode); | ||
| if (loanRepaymentScheduleTransactionProcessor instanceof AdvancedPaymentScheduleTransactionProcessor advancedProcessor) { | ||
| LocalDate currentDate = DateUtils.getBusinessLocalDate(); | ||
| if (interestRecognitionOnDisbursementDate && currentDate.equals(disbursementDate)) { |
There was a problem hiding this comment.
This looks not right... we cannot go into the future...
adamsaghy
requested changes
Nov 3, 2025
alberto-art3ch
force-pushed
the
FINERACT-2326/loan-contract-termination-in-disbursement-date
branch
from
149b2ba to
8cef0fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When user tries a Contract termination on disbursement day it results an 500-Integral server error because there were not an Installment to be updated
FINERACT-2326
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.