Open
Conversation
airajena
force-pushed
the
FINERACT-2004/limit-login-retries
branch
4 times, most recently
from
b44c9df to
2ba7017
Compare
Contributor
Author
|
Hi @adamsaghy , i checked the failed check |
airajena
force-pushed
the
FINERACT-2004/limit-login-retries
branch
2 times, most recently
from
9474e14 to
5ac562f
Compare
Contributor
|
@airajena Please rebase this PR with latest |
adamsaghy
reviewed
Feb 17, 2026
|
|
||
| @Getter | ||
| @Column(name = "failed_login_attempts", nullable = false) | ||
| private int failedLoginAttempts; |
Contributor
There was a problem hiding this comment.
Please make sure to introduce a new flag which controls whether this functionality is allowed on a particular account or not.
For example, the system account should NEVER be locked! Probably same applies to accounts which are used for API communication!
adamsaghy
requested changes
Feb 17, 2026
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Kindly see my concerns!
airajena
force-pushed
the
FINERACT-2004/limit-login-retries
branch
from
5ac562f to
baefdaa
Compare
airajena
force-pushed
the
FINERACT-2004/limit-login-retries
branch
from
baefdaa to
226afac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a configurable global setting to limit login retries and lock accounts after exceeding the configured threshold. Failed attempts are tracked per user, and a successful login resets the counter. This aligns with FINERACT-2004 and provides safer, configurable account protection without changing public APIs.
Key changes
max-login-retry-attempts(enabled flag + value).failed_login_attemptsonm_appuserand lock the user when the threshold is reached.Testing
./gradlew :fineract-core:spotlessApply :fineract-core:spotbugsMain :fineract-core:spotbugsTest :fineract-core:checkstyleMain :fineract-core:checkstyleTest./gradlew :fineract-provider:spotlessApply :fineract-provider:spotbugsMain :fineract-provider:spotbugsTest :fineract-provider:checkstyleMain :fineract-provider:checkstyleTest./gradlew :integration-tests:spotlessApply :integration-tests:spotbugsMain :integration-tests:spotbugsTest :integration-tests:checkstyleMain :integration-tests:checkstyleTestChecklist