FINERACT-1878: Separate profile image paths for staff and clients

[airajena]

Description

Fixes profile image path collision between Client and Staff entities when they share the same numeric ID.

Previously, image save operations always used the images/clients/{id} path, even for Staff uploads. This caused Staff and Client images with the same ID to overwrite/read from the same location.

Changes

• Updated ContentRepository image save method signatures to include entityName.
• Updated image write flow in ImageWritePlatformServiceJpaRepositoryImpl to pass the entity type (clients or staff) to the content repository.
• Updated FileSystemContentRepository image path generation to use:
  • images/clients/{id} for clients
  • images/staff/{id} for staff
• Updated S3ContentRepository image path generation with the same entity-specific behavior.

Testing

• Ran targeted compile checks:
  • ./gradlew :fineract-document:compileJava :fineract-provider:compileJava
• Ran targeted static analysis:
  • ./gradlew :fineract-document:spotbugsMain :fineract-provider:spotbugsMain :fineract-document:spotbugsTest :fineract-provider:spotbugsTest
• module-wide spotless/checkstyle currently reports pre-existing formatting/line-ending issues in unrelated files in this environment.

Related Issue

• FINERACT-1878 - Profile Image sharing between Client and Staff

[IOhacker]

Is there a possibility to add a Test class?

[airajena]

Is there a possibility to add a Test class?

Yes sure, will update and let u know

[IOhacker]

@airajena also please run ./gradlew :fineract-document:spotlessApply

[airajena]

@airajena also please run ./gradlew :fineract-document:spotlessApply

my bad, I have fixed it

[adamsaghy]

`The following files had format violations:
src/test/java/org/apache/fineract/infrastructure/documentmanagement/service/ImageWritePlatformServiceJpaRepositoryImplTest.java
@@ -74,8 +74,8 @@
········when(staff.getId()).thenReturn(entityId);
········when(staff.getImage()).thenReturn(null);

      -········CommandProcessingResult·result·=·service.saveOrUpdateImage("staff",·entityId,·"profile.png",·new·ByteArrayInputStream(new·byte[]·{·1,
      -················2,·3·}),·3L);
      +········CommandProcessingResult·result·=·service.saveOrUpdateImage("staff",·entityId,·"profile.png",
      +················new·ByteArrayInputStream(new·byte[]·{·1,·2,·3·}),·3L);
       
       ········verify(contentRepository).saveImage(any(ByteArrayInputStream.class),·eq("staff"),·eq(entityId),·eq("profile.png"),·eq(3L));
       ········verify(staff).setImage(any(Image.class));

Run './gradlew :fineract-provider:spotlessApply' to fix these violations.
`

[adamsaghy]

@airajena Please rebase your branch with latest develop branch!