Skip to content

FINERACT-2421: Refractor - If Else simplification and Lombok usage(Phase 9) #5502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Aman-Mittal wants to merge 1 commit into
base: develop
Choose a base branch
from
+88 −454
Draft

FINERACT-2421: Refractor - If Else simplification and Lombok usage(Phase 9) #5502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/java/org/apache/fineract/infrastructure/documentmanagement/api/ImagesApiResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ public Response retrieveImage(@PathParam("entity") final String entityName, @Pat
// Else return response with Base64 encoded
// TODO: Need a better way of determining image type
String imageDataURISuffix = ContentRepositoryUtils.ImageDataURIsuffix.JPEG.getValue();
if (StringUtils.endsWith(imageData.name(), ContentRepositoryUtils.ImageFileExtension.GIF.getValue())) {
if (StringUtils.endsWith(imageData.name(), ImageFileExtension.GIF.getValue())) {
imageDataURISuffix = ContentRepositoryUtils.ImageDataURIsuffix.GIF.getValue();
} else if (StringUtils.endsWith(imageData.name(), ContentRepositoryUtils.ImageFileExtension.PNG.getValue())) {
imageDataURISuffix = ContentRepositoryUtils.ImageDataURIsuffix.PNG.getValue();
Expand Down
26 changes: 6 additions & 20 deletions ...n/java/org/apache/fineract/infrastructure/documentmanagement/command/DocumentCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.fineract.infrastructure.documentmanagement.command;

import java.util.Set;
import lombok.Setter;

/**
* Immutable command for creating or updating details of a client identifier.
Expand All @@ -31,10 +32,15 @@ public class DocumentCommand {
private final String name;
private final String description;

@Setter
private String fileName;
@Setter
private Long size;
@Setter
private String type;
@Setter
private String location;
@Setter
private Integer storageType;

private final Set<String> modifiedParameters;
Expand Down Expand Up @@ -93,30 +99,10 @@ public Set<String> getModifiedParameters() {
return this.modifiedParameters;
}

public void setFileName(final String fileName) {
this.fileName = fileName;
}

public void setSize(final Long size) {
this.size = size;
}

public void setType(final String type) {
this.type = type;
}

public void setLocation(final String location) {
this.location = location;
}

public Integer getStorageType() {
return this.storageType;
}

public void setStorageType(final Integer storageType) {
this.storageType = storageType;
}

public boolean isNameChanged() {
return this.modifiedParameters.contains("name");
}
Expand Down
Loading
Loading