Open
Conversation
github-actions
bot
added
priority/major
|
@qingfei1994 Please add the following content to your PR description and select a checkbox: |
github-actions
bot
added
doc-not-needed
wenjin272
reviewed
Mar 19, 2026
Collaborator
wenjin272
left a comment
wenjin272
left a comment
There was a problem hiding this comment.
Hi, @qingfei1994, thanks for you work. The python part looks good to me, but the java part seems not complete.
| * @param jobName The name for the Flink job. | ||
| */ | ||
| public void execute(String jobName) throws Exception { | ||
| execute(); |
Collaborator
There was a problem hiding this comment.
The job name is not passed to the underlying Flink execution environment.
Contributor
Author
There was a problem hiding this comment.
My first thought is to providing an optional execute with jobName method for other execution environment like LocalExecutionEnvironment which doesn't support executing with jobName, but since then I think I would just provide an abstract method here.
Collaborator
|
The logic code looks good to me. Could you add test for the java api like what you do in python? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #560
Purpose of change
Users can customize Job Name of Flink Agents.
Tests
UnitTest
API
Yes
Documentation
doc-neededdoc-not-neededdoc-included