-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[FLINK-37203] Alter table comment or column comment #3893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
12578cb
[FLINK-37203] Alter table comment or column comment.
ChaomingZhangCN e01ed60
Address comment.
lvyanquan 7a4b7f1
Code opt.
lvyanquan d8d0118
Fix CI failure.
lvyanquan 04464c4
Address comments.
lvyanquan 2b653c2
Fix CI failure.
lvyanquan 5b11e73
Fix Ci failure.
lvyanquan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/AlterTableCommentEvent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.cdc.common.event; | ||
|
|
||
| import org.apache.flink.cdc.common.annotation.PublicEvolving; | ||
| import org.apache.flink.cdc.common.utils.Preconditions; | ||
|
|
||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * A {@link SchemaChangeEvent} that represents an {@code ALTER TABLE COMMENT} or {@code ALTER TABLE | ||
| * SET COMMENT} DDL. | ||
| */ | ||
| @PublicEvolving | ||
| public class AlterTableCommentEvent implements SchemaChangeEvent { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final TableId tableId; | ||
| private final String comment; | ||
|
|
||
| public AlterTableCommentEvent(TableId tableId, String comment) { | ||
| Preconditions.checkArgument(comment != null, "comment should not be null."); | ||
| this.tableId = tableId; | ||
| this.comment = comment; | ||
| } | ||
|
|
||
| public String getComment() { | ||
| return comment; | ||
| } | ||
|
|
||
| @Override | ||
| public SchemaChangeEventType getType() { | ||
| return SchemaChangeEventType.ALTER_TABLE_COMMENT; | ||
| } | ||
|
|
||
| @Override | ||
| public SchemaChangeEvent copy(TableId newTableId) { | ||
| return new AlterTableCommentEvent(newTableId, comment); | ||
| } | ||
|
|
||
| @Override | ||
| public TableId tableId() { | ||
| return tableId; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (!(o instanceof AlterTableCommentEvent)) { | ||
| return false; | ||
| } | ||
| AlterTableCommentEvent that = (AlterTableCommentEvent) o; | ||
| return Objects.equals(tableId, that.tableId) && Objects.equals(comment, that.comment); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(tableId, comment); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "AlterTableCommentEvent{" | ||
| + "tableId=" | ||
| + tableId | ||
| + ", comment='" | ||
| + comment | ||
| + '\'' | ||
| + '}'; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
...rc/main/java/org/apache/flink/cdc/common/event/visitor/AlterTableCommentEventVisitor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.cdc.common.event.visitor; | ||
|
|
||
| import org.apache.flink.cdc.common.annotation.Internal; | ||
| import org.apache.flink.cdc.common.event.AlterTableCommentEvent; | ||
|
|
||
| /** Visitor for {@link AlterTableCommentEvent}s. */ | ||
| @Internal | ||
| @FunctionalInterface | ||
| public interface AlterTableCommentEventVisitor<T, E extends Throwable> { | ||
| T visit(AlterTableCommentEvent event) throws E; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.