[FLINK-38730][build] Bump jdk version from 8 to 11.#4187
Conversation
| </plugins> | ||
| </build> | ||
| </profile> | ||
| <profile> |
There was a problem hiding this comment.
As we're running tests against Java 17 in nightly builds, shall we create a java-17-target profile and activate it with [17,)?
yuxiqian
left a comment
yuxiqian
left a comment
There was a problem hiding this comment.
Looks good except one minor comment.
|
Tested this PR with Java 17 in yuxiqian#123, seems some cases are failing because we need to explicitly |
lvyanquan
force-pushed
the
FLINK-38730
branch
3 times, most recently
from
5559021 to
9d536f5
Compare
Done. |
|
Hi @leonardBang, PTAL. |
yuxiqian
left a comment
yuxiqian
left a comment
There was a problem hiding this comment.
+1, thanks @lvyanquan for the nice work.
| <java> | ||
| <googleJavaFormat> | ||
| <version>1.7</version> | ||
| <version>1.10.0</version> |
There was a problem hiding this comment.
nit: It's ideal to follow Flink code format style (AOSP 1.24.0).
As that would result in changes in many files, we could do it later.
There was a problem hiding this comment.
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
LGTM, @lvyanquan could you keep two commits including (1) bump jdk11 and (2) support jdk17
lvyanquan
force-pushed
the
FLINK-38730
branch
from
3c1675a to
5e102dc
Compare
…t optional JDK17 This closes apache#4187.
3 participants
Bump jdk version from 8 to 11.
This will allow us to gradually start the compatibility work with Flink 2.x, Debezium 2.x, and Iceberg 1.10+.