[FLINK-38021] [cdc connector mysql] Support double quotes in MySQL DDL parsing for DEFAULT VALUE and COMMENT#4219
Closed
ThorneANN wants to merge 2 commits into
Closed
[FLINK-38021] [cdc connector mysql] Support double quotes in MySQL DDL parsing for DEFAULT VALUE and COMMENT#4219ThorneANN wants to merge 2 commits into
ThorneANN wants to merge 2 commits into
Conversation
…VALUE and COMMENT This commit enhances the MySQL CDC connectors to correctly parse DDL statements containing both single quotes and double quotes in DEFAULT VALUE and COMMENT clauses. Changes: - flink-connector-mysql-cdc: Updated DefaultValueParserListener.unquote() to handle both single and double quotes for DEFAULT VALUE parsing - flink-cdc-pipeline-connector-mysql: Added MySqlSchemaUtils.removeQuotes() utility method to handle both quote types for COMMENT parsing - Updated CustomColumnDefinitionParserListener and CustomAlterTableParserListener to use the new removeQuotes() method Tests: - Added DefaultValueParserListenerTest with 5 unit tests - Added MySqlSchemaUtilsTest with 7 unit tests - Added MySqlCommentParsingITCase with 4 integration tests This change ensures robust parsing of binlog events that may use either single or double quotes, as MySQL normalizes double quotes to single quotes in SHOW CREATE TABLE output but binlog events may contain either type. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enhances the MySQL CDC connectors to correctly parse DDL statements
containing both single quotes and double quotes in DEFAULT VALUE and COMMENT clauses.
Changes:
both single and double quotes for DEFAULT VALUE parsing
method to handle both quote types for COMMENT parsing
to use the new removeQuotes() method
Tests:
This change ensures robust parsing of binlog events that may use either single
or double quotes, as MySQL normalizes double quotes to single quotes in
SHOW CREATE TABLE output but binlog events may contain either type.