Skip to content

[FLINK-37837][core] Always add create.table to include.schema.changes option#4262

Merged
lvyanquan merged 2 commits into
apache:masterfrom
Hisoka-X:FLINK-37837-schema-change-option
Mar 20, 2026
Merged

[FLINK-37837][core] Always add create.table to include.schema.changes option#4262
lvyanquan merged 2 commits into
apache:masterfrom
Hisoka-X:FLINK-37837-schema-change-option

Conversation

@Hisoka-X
Copy link
Copy Markdown
Member

@Hisoka-X Hisoka-X commented Feb 5, 2026

This close https://issues.apache.org/jira/browse/FLINK-37837

This pull request ensures that the CreateTableEvent is always included in the set of schema change events unless the user explicitly excludes it. This change guarantees the foundational event is present for proper schema evolution handling.

@github-actions github-actions Bot added the cli label Feb 5, 2026
@Hisoka-X Hisoka-X closed this Feb 9, 2026
@Hisoka-X Hisoka-X reopened this Feb 9, 2026
@ThorneANN
Copy link
Copy Markdown
Contributor

Thank you for your contribution and i left some comment

@ThorneANN
Copy link
Copy Markdown
Contributor

I think that always add create.table to include.schema.changes option is not a good idea ,because user can create table without flink-cdc and others

@Hisoka-X
Copy link
Copy Markdown
Member Author

I think that always add create.table to include.schema.changes option is not a good idea ,because user can create table without flink-cdc and others

Users can set create.table into exclude.schema.changes.

@ThorneANN
Copy link
Copy Markdown
Contributor

and i think the jira's error was

I think that always add create.table to include.schema.changes option is not a good idea ,because user can create table without flink-cdc and others

Users can set create.table into exclude.schema.changes.

I think this is the correct processing logic, if users always create tables first, and creating tables may be a failure that leads to task failure.

@Hisoka-X
Copy link
Copy Markdown
Member Author

Hisoka-X commented Mar 6, 2026

cc @lvyanquan

@github-actions github-actions Bot added the docs Improvements or additions to documentation label Mar 19, 2026
Copy link
Copy Markdown
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CC @lvyanquan

Copy link
Copy Markdown
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@lvyanquan lvyanquan merged commit 8d5be44 into apache:master Mar 20, 2026
21 of 22 checks passed
Mrart pushed a commit to Mrart/flink-cdc that referenced this pull request Mar 26, 2026
ThorneANN pushed a commit to ThorneANN/flink-cdc that referenced this pull request Mar 31, 2026
@Hisoka-X Hisoka-X deleted the FLINK-37837-schema-change-option branch April 7, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cli docs Improvements or additions to documentation reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants