Skip to content
Closed
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
import java.util.Map;
import java.util.Set;

import static org.apache.flink.cdc.connectors.fluss.sink.FlussConfigUtils.parseBucketKeys;
import static org.apache.flink.cdc.connectors.fluss.sink.FlussConfigUtils.parseBucketNumber;
import static org.apache.flink.cdc.connectors.fluss.sink.FlussDataSinkOptions.BOOTSTRAP_SERVERS;
import static org.apache.flink.cdc.connectors.fluss.sink.FlussDataSinkOptions.BUCKET_KEY;
import static org.apache.flink.cdc.connectors.fluss.sink.FlussDataSinkOptions.BUCKET_NUMBER;
import static org.apache.flink.cdc.connectors.fluss.sink.FlussDataSinkOptions.CLIENT_PROPERTIES_PREFIX;
import static org.apache.flink.cdc.connectors.fluss.sink.FlussDataSinkOptions.TABLE_PROPERTIES_PREFIX;
import static org.apache.flink.cdc.connectors.fluss.utils.FlussConfigUtils.parseBucketKeys;
import static org.apache.flink.cdc.connectors.fluss.utils.FlussConfigUtils.parseBucketNumber;

/** Factory for creating configured instances of {@link FlussDataSink}. */
public class FlussDataSinkFactory implements DataSinkFactory {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

package org.apache.flink.cdc.connectors.fluss.sink;
package org.apache.flink.cdc.connectors.fluss.utils;

import javax.annotation.Nullable;

Expand All @@ -24,7 +24,7 @@
import java.util.List;
import java.util.Map;

/** Utils for parsing fluss yaml sink options. */
/** Utils for parsing fluss Yaml sink options. */
public class FlussConfigUtils {
public static Map<String, List<String>> parseBucketKeys(@Nullable String rawValue)
throws IllegalArgumentException {
Expand Down Expand Up @@ -64,18 +64,17 @@ public static Map<String, Integer> parseBucketNumber(@Nullable String rawValue)
String[] kv = tableBucketNumStr.trim().split(":", 2);
if (kv.length != 2) {
throw new IllegalArgumentException(
"Invalid bucket number configuration: " + rawValue);
"Invalid bucket number configuration for : " + rawValue);
}

String table = kv[0].trim();
try {
int value = Integer.parseInt(kv[1].trim());
result.put(table, value);
result.put(kv[0].trim(), Integer.valueOf(kv[1].trim()));
} catch (NumberFormatException ignored) {
throw new IllegalArgumentException(
"Invalid bucket number configuration: " + rawValue);
"Invalid bucket number configuration for : " + rawValue);
}
}
return result;
}

private FlussConfigUtils() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ void testWrongBucketKeyAndBucketNum() {
.build()),
new Configuration(),
Thread.currentThread().getContextClassLoader())))
.hasMessageContaining("Invalid bucket number configuration: database1.table1: 11a");
.hasMessageContaining(
"Invalid bucket number configuration for : database1.table1: 11a");
}

private Configuration createValidConfiguration() {
Expand Down
Loading